Skip to content

Commit

Permalink
branch: mention start_name in set-upstream error messages
Browse files Browse the repository at this point in the history
If we refuse a branch operation because the tracking
start_name the user gave us is bogus, we just print
something like:

 fatal: Cannot setup tracking information; start point is not a branch

If we mention the actual name we tried to use, that may help
the user figure out why it didn't work (e.g., if they gave
us the arguments in the wrong order).

Signed-off-by: Jeff King <[email protected]>
Signed-off-by: Junio C Hamano <[email protected]>
  • Loading branch information
peff authored and gitster committed Apr 2, 2013
1 parent a5e91c7 commit 1a15d00
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions branch.c
Original file line number Diff line number Diff line change
Expand Up @@ -198,9 +198,9 @@ int validate_new_branchname(const char *name, struct strbuf *ref,
}

static const char upstream_not_branch[] =
N_("Cannot setup tracking information; starting point is not a branch.");
N_("Cannot setup tracking information; starting point '%s' is not a branch.");
static const char upstream_missing[] =
N_("Cannot setup tracking information; starting point does not exist");
N_("Cannot setup tracking information; starting point '%s' does not exist");

void create_branch(const char *head,
const char *name, const char *start_name,
Expand Down Expand Up @@ -231,22 +231,22 @@ void create_branch(const char *head,
real_ref = NULL;
if (get_sha1(start_name, sha1)) {
if (explicit_tracking)
die(_(upstream_missing));
die(_(upstream_missing), start_name);
die("Not a valid object name: '%s'.", start_name);
}

switch (dwim_ref(start_name, strlen(start_name), sha1, &real_ref)) {
case 0:
/* Not branching from any existing branch */
if (explicit_tracking)
die(_(upstream_not_branch));
die(_(upstream_not_branch), start_name);
break;
case 1:
/* Unique completion -- good, only if it is a real branch */
if (prefixcmp(real_ref, "refs/heads/") &&
prefixcmp(real_ref, "refs/remotes/")) {
if (explicit_tracking)
die(_(upstream_not_branch));
die(_(upstream_not_branch), start_name);
else
real_ref = NULL;
}
Expand Down

0 comments on commit 1a15d00

Please sign in to comment.