bpo-32013: _pickle: Add missing Py_DECREF in error case in fast_save_…

…enter() (python#4384)
bigjordon · Nov 13, 2017 · f76231f · f76231f
1 parent 8acaa31
commit f76231f
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/Modules/_pickle.c b/Modules/_pickle.c
@@ -1777,8 +1777,10 @@ fast_save_enter(PicklerObject *self, PyObject *obj)
             }
         }
         key = PyLong_FromVoidPtr(obj);
-        if (key == NULL)
+        if (key == NULL) {
+            self->fast_nesting = -1;
             return 0;
+        }
         if (PyDict_GetItemWithError(self->fast_memo, key)) {
             Py_DECREF(key);
             PyErr_Format(PyExc_ValueError,
@@ -1789,6 +1791,8 @@ fast_save_enter(PicklerObject *self, PyObject *obj)
             return 0;
         }
         if (PyErr_Occurred()) {
+            Py_DECREF(key);
+            self->fast_nesting = -1;
             return 0;
         }
         if (PyDict_SetItem(self->fast_memo, key, Py_None) < 0) {