Skip to content

Commit

Permalink
libceph: move a dout in queue_con_delay()
Browse files Browse the repository at this point in the history
The queued con->work can start executing (and therefore logging)
before we get to this "con->work has been queued" message, making
the logs confusing.  Move it up, with the meaning of "con->work
is about to be queued".

Signed-off-by: Ilya Dryomov <[email protected]>
  • Loading branch information
idryomov committed Oct 12, 2020
1 parent c74d79a commit 5a5036c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion net/ceph/messenger.c
Original file line number Diff line number Diff line change
Expand Up @@ -2811,13 +2811,13 @@ static int queue_con_delay(struct ceph_connection *con, unsigned long delay)
return -ENOENT;
}

dout("%s %p %lu\n", __func__, con, delay);
if (!queue_delayed_work(ceph_msgr_wq, &con->work, delay)) {
dout("%s %p - already queued\n", __func__, con);
con->ops->put(con);
return -EBUSY;
}

dout("%s %p %lu\n", __func__, con, delay);
return 0;
}

Expand Down

0 comments on commit 5a5036c

Please sign in to comment.