Appease eslint, allow deliberate unused vars (automerge#284)

Along with a few small changes to fix eslint complaints add a rule which allows unused variables in typescript files if the variable in question is prefixed with "_".
bijela-gora · Jan 30, 2024 · aadf0f3 · aadf0f3
1 parent 23d8461
commit aadf0f3
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 3 deletions.
diff --git a/.eslintrc.cjs b/.eslintrc.cjs
@@ -49,6 +49,7 @@ module.exports = {
     "no-use-before-define": OFF,
     "@typescript-eslint/no-non-null-assertion": OFF,
     "@typescript-eslint/no-explicit-any": OFF,
+    "@typescript-eslint/no-unused-vars": [ERROR, {"varsIgnorePattern": "^_"}],
   },
   root: true,
 }
diff --git a/packages/automerge-repo-network-websocket/src/BrowserWebSocketClientAdapter.ts b/packages/automerge-repo-network-websocket/src/BrowserWebSocketClientAdapter.ts
@@ -24,7 +24,7 @@ abstract class WebSocketNetworkAdapter extends NetworkAdapter {
 }
 
 export class BrowserWebSocketClientAdapter extends WebSocketNetworkAdapter {
-  #isReady: boolean = false
+  #isReady = false
   #retryIntervalId?: TimeoutId
   #log = debug("automerge-repo:websocket:browser")
 

diff --git a/packages/automerge-repo-react-hooks/src/useDocuments.ts b/packages/automerge-repo-react-hooks/src/useDocuments.ts
@@ -54,6 +54,8 @@ export const useDocuments = <T>(ids?: DocId[]) => {
           handle.doc().then(doc => {
             updateDocument(id, doc)
             addListener(handle)
+          }).catch(err => {
+            console.error(`Error loading document ${id} in useDocuments: `, err)
           })
         })
 

diff --git a/packages/automerge-repo-storage-nodefs/src/index.ts b/packages/automerge-repo-storage-nodefs/src/index.ts
@@ -19,7 +19,7 @@ export class NodeFSStorageAdapter extends StorageAdapter {
   /**
    * @param baseDirectory - The path to the directory to store data in. Defaults to "./automerge-repo-data".
    */
-  constructor(baseDirectory: string = "automerge-repo-data") {
+  constructor(baseDirectory = "automerge-repo-data") {
     super()
     this.baseDirectory = baseDirectory
   }

diff --git a/packages/automerge-repo/src/DocHandle.ts b/packages/automerge-repo/src/DocHandle.ts
@@ -39,7 +39,7 @@ export class DocHandle<T> //
   #log: debug.Debugger
 
   #machine: DocHandleXstateMachine<T>
-  #timeoutDelay: number = 60_000
+  #timeoutDelay = 60_000
   #remoteHeads: Record<StorageId, A.Heads> = {}
 
   /** The URL of this document