Skip to content

Commit

Permalink
Add role bindings and cluster role bindings, organize groups and impr…
Browse files Browse the repository at this point in the history
…ove the CRD names (kubernetes#5448)

* Display basics of role bindings

* Improve the CRD display names

* Move storage classes to the correct section

* Display basics of cluster role bindings

* Add role references

* Add subjects

* Fix typo

* Update cluster group view

* Update search view

* Sort sections and update workloads section

* Update menu order

* Fix review findings
  • Loading branch information
Marcin Maciaszczyk authored Aug 27, 2020
1 parent 4972092 commit bc2d311
Show file tree
Hide file tree
Showing 46 changed files with 3,395 additions and 1,599 deletions.
724 changes: 429 additions & 295 deletions i18n/fr/messages.fr.xlf

Large diffs are not rendered by default.

469 changes: 304 additions & 165 deletions i18n/ja/messages.ja.xlf

Large diffs are not rendered by default.

492 changes: 304 additions & 188 deletions i18n/ko/messages.ko.xlf

Large diffs are not rendered by default.

394 changes: 251 additions & 143 deletions i18n/messages.xlf

Large diffs are not rendered by default.

492 changes: 304 additions & 188 deletions i18n/zh-Hans/messages.zh-Hans.xlf

Large diffs are not rendered by default.

492 changes: 304 additions & 188 deletions i18n/zh-Hant-HK/messages.zh-Hant-HK.xlf

Large diffs are not rendered by default.

492 changes: 304 additions & 188 deletions i18n/zh-Hant/messages.zh-Hant.xlf

Large diffs are not rendered by default.

2 changes: 2 additions & 0 deletions src/app/backend/api/types.go
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,9 @@ var KindToAPIMapping = map[string]APIMapping{
ResourceKindEndpoint: {"endpoints", ClientTypeDefault, true},
ResourceKindNetworkPolicy: {"networkpolicies", ClientTypeNetworkingClient, true},
ResourceKindClusterRole: {"clusterroles", ClientTypeRbacClient, false},
ResourceKindClusterRoleBinding: {"clusterrolebindings", ClientTypeRbacClient, false},
ResourceKindRole: {"roles", ClientTypeRbacClient, true},
ResourceKindRoleBinding: {"rolebindings", ClientTypeRbacClient, true},
ResourceKindPlugin: {"plugins", ClientTypePluginsClient, true},
}

Expand Down
4 changes: 4 additions & 0 deletions src/app/frontend/chrome/nav/pinner/component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -47,4 +47,8 @@ export class PinnerNavComponent {
unpin(resource: PinnedResource): void {
this.pinner_.unpinResource(resource);
}

getDisplayName(resource: PinnedResource): string {
return resource.displayName.replace(/([A-Z]+)/g, ' $1').replace(/([A-Z][a-z])/g, ' $1');
}
}
2 changes: 1 addition & 1 deletion src/app/frontend/chrome/nav/pinner/template.html
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,6 @@
class="kd-nav-item"
[state]="getResourceHref(resource)"
[namespaced]="resource.namespaced"
i18n>{{resource.displayName}}
i18n>{{getDisplayName(resource)}}
</kd-nav-item>
</div>
12 changes: 0 additions & 12 deletions src/app/frontend/chrome/nav/style.scss
Original file line number Diff line number Diff line change
Expand Up @@ -42,18 +42,6 @@
}
}

.kd-nav-group {
margin-right: $baseline-grid;

&:last-child {
> .kd-nav-item {
&:last-child {
padding-bottom: 2 * $baseline-grid;
}
}
}
}

.kd-nav-group-item {
margin-left: 1.5 * $baseline-grid;
}
Expand Down
Loading

0 comments on commit bc2d311

Please sign in to comment.