Skip to content

Commit

Permalink
Bump node.js 11.6.0 to 12.16.0 LTS (kubernetes#4899)
Browse files Browse the repository at this point in the history
Now dashboard supports nodejs 11.6.0, but it had been end-of-life already.
So bump nodejs 11.6.0 to 12.16.0 LTS.
  • Loading branch information
shu-mutou authored Feb 12, 2020
1 parent e8043fa commit ffadb9e
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
sudo: required
dist: bionic
language: node_js
node_js: 11.6.0
node_js: 12.16.0

apt:
packages:
Expand Down
4 changes: 2 additions & 2 deletions aio/develop/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@ FROM golang:1.12
# Install Node.js. Go is already installed.
# A small tweak, apt-get update is already run by the nodejs setup script,
# so there's no need to run it again.
RUN curl -sL https://deb.nodesource.com/setup_11.x | bash - \
&& apt-get install -y --no-install-recommends \
RUN curl -sL https://deb.nodesource.com/setup_12.x | bash - \
&& apt-get install -y --no-install-recommends \
nodejs \
patch \
chromium \
Expand Down
2 changes: 1 addition & 1 deletion docs/developer/getting-started.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ Make sure the following software is installed and added to the $PATH variable:
* Docker 1.13.1+ ([installation manual](https://docs.docker.com/engine/installation/linux/docker-ce/ubuntu/))
* Golang 1.12.0+ ([installation manual](https://golang.org/dl/))
* Dashboard uses `go mod` for go dependency management, so enable it with running `export GO111MODULE=on`.
* Node.js 11+ and npm 6+ ([installation with nvm](https://github.com/creationix/nvm#usage))
* Node.js 12+ and npm 6+ ([installation with nvm](https://github.com/creationix/nvm#usage))
* Gulp.js 4+ ([installation manual](https://github.com/gulpjs/gulp/blob/master/docs/getting-started/1-quick-start.md))

Clone the repository into `$GOPATH/src/github.com/kubernetes/dashboard` and install the dependencies:
Expand Down

0 comments on commit ffadb9e

Please sign in to comment.