CI - Reusable workflows #392
Conversation
PrimozGodec
force-pushed
the
reusable-workflows
branch
from
b5b1066 to
6c5f8f2
Compare
| @@ -198,7 +198,8 @@ def transform(self, data): | |||
| else: | |||
| Xc = INV_LINKS[self.link](LINKS[self.link](Xc) - Z.dot(W)) | |||
| new_data = data.copy() | |||
| new_data.X = Xc | |||
| with new_data.unlocked(new_data.X): | |||
There was a problem hiding this comment.
Here we only need to unlock the reference (would work even if contents of X would be unlockable)
| new_data.X = new_data.X >= self.threshold | ||
| elif self.condition == Binarize.Greater: | ||
| new_data.X = new_data.X > self.threshold | ||
| with new_data.unlocked(new_data.X): |
There was a problem hiding this comment.
Same, unlock only reference
| @@ -147,9 +150,11 @@ def __init__(self, lower_bound=None, upper_bound=None): | |||
| def __call__(self, data): | |||
| new_data = data.copy() | |||
| with np.errstate(invalid="ignore"): | |||
| new_data.X = np.nan_to_num(zscore(data.X)) | |||
| with new_data.unlocked(new_data.X): | |||
There was a problem hiding this comment.
Both should only unlock reference
There was a problem hiding this comment.
Second one seems to need actual unlock of array.
PrimozGodec
force-pushed
the
reusable-workflows
branch
from
edbed61 to
903fe9c
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #392 +/- ##
==========================================
+ Coverage 80.49% 80.57% +0.07%
==========================================
Files 21 21
Lines 5450 5471 +21
==========================================
+ Hits 4387 4408 +21
Misses 1063 1063
Continue to review full report at Codecov.
|
PrimozGodec
force-pushed
the
reusable-workflows
branch
2 times, most recently
from
0ee6212 to
5954734
Compare
PrimozGodec
force-pushed
the
reusable-workflows
branch
from
5954734 to
0d3db91
Compare
|
@markotoplak I changed what you suggested. There are some new failing tests here cased by adding pyqt6 testing in matrix (orange-ci-cd repo). It is fixed in #393 and should be merged after. |
|
Thanks, @PrimozGodec. |
Description of changes
Reusable workflow for testing and automatic rebase
Includes