Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Sentiment Analysis: Add SentiArt method #605

Merged
merged 2 commits into from
Jan 20, 2021

Conversation

ajdapretnar
Copy link
Collaborator

@ajdapretnar ajdapretnar commented Dec 10, 2020

Issue

Implements SentiArt for extracting sentiment for literary texts.

Based on #609.

Description of changes

Add SentiArt.
Make SentimentDictionaries a base class and derive MultilingualSentiment and SentiArt from it.
Tests.

Includes
  • Code changes
  • Tests
  • Documentation

@ajdapretnar
Copy link
Collaborator Author

I removed the two files from the sentiment folder on files.biolab as they broke existing loading of files in Sentiment Analysis. Looking for solutions to add them.

@ajdapretnar ajdapretnar changed the title OWSentimentAnalysis: Add SentiArt method [WIP] OWSentimentAnalysis: Add SentiArt method Dec 11, 2020
@codecov-io
Copy link

Codecov Report

Merging #605 (e7308cd) into master (53e0da6) will increase coverage by 0.00%.
The diff coverage is 71.05%.

@@           Coverage Diff           @@
##           master     #605   +/-   ##
=======================================
  Coverage   73.98%   73.98%           
=======================================
  Files          66       66           
  Lines        7781     7839   +58     
  Branches     1026     1035    +9     
=======================================
+ Hits         5757     5800   +43     
- Misses       1814     1826   +12     
- Partials      210      213    +3     

@ajdapretnar ajdapretnar changed the title [WIP] OWSentimentAnalysis: Add SentiArt method OWSentimentAnalysis: Add SentiArt method Jan 15, 2021
@lanzagar lanzagar changed the title OWSentimentAnalysis: Add SentiArt method [ENH] Sentiment Analysis: Add SentiArt method Jan 20, 2021
@lanzagar lanzagar merged commit aa10616 into biolab:master Jan 20, 2021
@ajdapretnar ajdapretnar deleted the senti-art branch January 21, 2021 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants