Skip to content

Commit

Permalink
res_format_attr_h264.c: Make sure profile-level-id fmtp attribute is set
Browse files Browse the repository at this point in the history
The profile-iop octet (the 2nd) of profile-level-id can be zero
according to RFC 6184 Section 8.1. So we ignore its value when deciding
to include profile-level-id in the outgoing SDP.

ASTERISK-27959 #close
Reported by: David Kuehling

Change-Id: Id28cd916a3d7748058fe9609b585d07d9e243f73
  • Loading branch information
seanbright committed Dec 13, 2018
1 parent b701c8b commit 5b12dfa
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion res/res_format_attr_h264.c
Original file line number Diff line number Diff line change
Expand Up @@ -282,7 +282,7 @@ static void h264_generate_sdp_fmtp(const struct ast_format *format, unsigned int
APPEND_IF_NOT_H264_UNSET(attr->PACKETIZATION_MODE, str, "packetization-mode");
APPEND_IF_NOT_H264_UNSET(attr->LEVEL_ASYMMETRY_ALLOWED, str, "level-asymmetry-allowed");

if (attr->PROFILE_IDC && attr->PROFILE_IOP && attr->LEVEL) {
if (attr->PROFILE_IDC && attr->LEVEL) {
if (added) {
ast_str_append(str, 0, ";");
} else if (0 < ast_str_append(str, 0, "a=fmtp:%u ", payload)) {
Expand Down

0 comments on commit 5b12dfa

Please sign in to comment.