Skip to content

Commit

Permalink
Rename generated Version.cpp to version.cpp
Browse files Browse the repository at this point in the history
The convention is to use capitalized filenames for source files that
implement classes and namespaces and lowercase filenames for source
files that do not.
  • Loading branch information
jrosdahl committed Jun 23, 2020
1 parent ee332b4 commit e82d6e0
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 5 deletions.
5 changes: 3 additions & 2 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,9 @@ ccache-*.tar.*
perfdir.*
testdir.*

# Version is generated into src, because it should be included into src packages
/src/Version.cpp
# version.cpp is generated in src because it should be included into source
# packages
/src/version.cpp

# Typical build directories
/build*
Expand Down
6 changes: 4 additions & 2 deletions cmake/GenerateVersionFile.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,8 @@ get_version_from_git()
if(VERSION_ERROR)
message(STATUS "Not within git repository")
else()
configure_file(${CMAKE_SOURCE_DIR}/cmake/Version.cpp.in
${CMAKE_SOURCE_DIR}/src/Version.cpp @ONLY)
configure_file(
${CMAKE_SOURCE_DIR}/cmake/version.cpp.in
${CMAKE_SOURCE_DIR}/src/version.cpp
@ONLY)
endif()
File renamed without changes.
2 changes: 1 addition & 1 deletion src/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ set(
manifest.cpp
result.cpp
stats.cpp
Version.cpp)
version.cpp)

if(INODE_CACHE_SUPPORTED)
list(APPEND source_files InodeCache.cpp)
Expand Down

0 comments on commit e82d6e0

Please sign in to comment.