Fix: do not declare queue on publish

bit-wiz · Dec 12, 2023 · 177c15e · 177c15e
1 parent 353065a
commit 177c15e
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/mq/rabbitmq.go b/mq/rabbitmq.go
@@ -169,9 +169,6 @@ func (b *RabbitMQBroker) PublishTask(ctx context.Context, qname string, t *tork.
 		return errors.Wrapf(err, "error creating channel")
 	}
 	defer ch.Close()
-	if err := b.declareQueue(exchangeDefault, keyDefault, qname, ch); err != nil {
-		return errors.Wrapf(err, "error (re)declaring queue")
-	}
 	return b.publish(ctx, exchangeDefault, qname, t)
 }
 

diff --git a/mq/rabbitmq_test.go b/mq/rabbitmq_test.go
@@ -33,7 +33,9 @@ func TestRabbitMQGetQueues(t *testing.T) {
 	b, err := NewRabbitMQBroker("amqp://guest:guest@localhost:5672/")
 	assert.NoError(t, err)
 	qname := fmt.Sprintf("%stest-%s", QUEUE_EXCLUSIVE_PREFIX, uuid.NewUUID())
-	err = b.PublishTask(ctx, qname, &tork.Task{})
+	err = b.SubscribeForTasks(qname, func(t *tork.Task) error {
+		return nil
+	})
 	assert.NoError(t, err)
 	qis, err := b.Queues(ctx)
 	assert.NoError(t, err)
@@ -51,7 +53,9 @@ func TestRabbitMQGetQueuesMgmtURL(t *testing.T) {
 	b, err := NewRabbitMQBroker("amqp://guest:guest@localhost:5672/", WithManagementURL("http://localhost:15672"))
 	assert.NoError(t, err)
 	qname := fmt.Sprintf("%stest-%s", QUEUE_EXCLUSIVE_PREFIX, uuid.NewUUID())
-	err = b.PublishTask(ctx, qname, &tork.Task{})
+	err = b.SubscribeForTasks(qname, func(t *tork.Task) error {
+		return nil
+	})
 	assert.NoError(t, err)
 	qis, err := b.Queues(ctx)
 	assert.NoError(t, err)