Skip to content
This repository has been archived by the owner on Apr 30, 2020. It is now read-only.

Add basic test with mocha, chai #75

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Add basic test with mocha, chai #75

wants to merge 6 commits into from

Conversation

eveninglily
Copy link
Member

  • Basic test of /auth/register endpoint

@eveninglily eveninglily added the enhancement New feature or request label Mar 7, 2019
@eveninglily eveninglily requested a review from nyaculak March 7, 2019 23:23
@eveninglily
Copy link
Member Author

I have a few things I want to fix before merging this.
Namely, the require('dotenv') call doesn't actually load the env variables, and I also want to add an example of a test that will fail.

Also, I'll restore the deleted package-lock.json

Copy link
Member

@nyaculak nyaculak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks ready to merge once we fix the (very) small issues I commented on.

app/test/test.js Outdated

const User = require('../server/models/User');

let chai = require('chai');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should probably be const

app/test/test.js Outdated


/**
* Test the following in on scoop:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit - spelling: on => one

@eveninglily
Copy link
Member Author

I'm not sure how to undo the horrendous things I seemed to have done to package-lock.json

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants