Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EPROD-956 unstable reqwest tests #187

Merged
merged 3 commits into from
Aug 16, 2024
Merged

EPROD-956 unstable reqwest tests #187

merged 3 commits into from
Aug 16, 2024

Conversation

veeso
Copy link
Member

@veeso veeso commented Aug 12, 2024 •
edited
Loading

Issue ticket

Issue ticket link: https://infinityswap.atlassian.net/browse/EPROD-956

Checklist before requesting a review

Code conventions

  • I have performed a self-review of my code
  • Every new function is documented
  • Object names are auto explicative

Security

  • The PR does not break APIs backward compatibility
  • The PR does not break the stable storage backward compatibility

Testing

  • Every function is properly unit tested
  • I have added integration tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • IC endpoints are always tested through the canister_call! macro

@veeso veeso marked this pull request as draft August 12, 2024 12:24
@veeso veeso marked this pull request as ready for review August 14, 2024 11:40
@veeso veeso requested a review from ufoscout August 14, 2024 16:05
@veeso veeso requested a review from ufoscout August 16, 2024 07:35
@veeso veeso merged commit 82be017 into main Aug 16, 2024
3 checks passed
@veeso veeso deleted the EPROD-956-bitfinity-evm-sdk-unstable-tests branch August 16, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itsyaasir itsyaasir itsyaasir approved these changes

@ufoscout ufoscout ufoscout approved these changes

@Maximkaaa Maximkaaa Awaiting requested review from Maximkaaa

@F3kilo F3kilo Awaiting requested review from F3kilo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@veeso @ufoscout @itsyaasir