Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Eprod-1000] legacy tx type #192

Merged
merged 5 commits into from
Sep 16, 2024
Merged

[Eprod-1000] legacy tx type #192

merged 5 commits into from
Sep 16, 2024

Conversation

ufoscout
Copy link
Contributor

@ufoscout ufoscout commented Sep 11, 2024 •
edited
Loading

Issue ticket

Issue ticket link:
https://infinityswap.atlassian.net/browse/EPROD-1000

Checklist before requesting a review

Code conventions

  • I have performed a self-review of my code
  • Every new function is documented
  • Object names are auto explicative

Security

  • The PR does not break APIs backward compatibility
  • The PR does not break the stable storage backward compatibility

Testing

  • Every function is properly unit tested
  • I have added integration tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • IC endpoints are always tested through the canister_call! macro

@ufoscout ufoscout merged commit 6e01bee into main Sep 16, 2024
3 checks passed
@ufoscout ufoscout deleted the EPROD-1000_legacy_tx_type branch September 16, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@F3kilo F3kilo F3kilo approved these changes

@itsyaasir itsyaasir itsyaasir approved these changes

@Maximkaaa Maximkaaa Awaiting requested review from Maximkaaa

@veeso veeso Awaiting requested review from veeso

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ufoscout @itsyaasir @F3kilo