Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EPROD-424] remove user registration from emvc #20

Merged
merged 21 commits into from
Jul 12, 2023
Merged

[EPROD-424] remove user registration from emvc #20

merged 21 commits into from
Jul 12, 2023

Conversation

itsyaasir
Copy link
Contributor

Issue ticket

Issue ticket link: <>

Checklist before requesting a review

Code conventions

  • I have performed a self-review of my code
  • Every new function is documented
  • Object names are auto explicative

Security

  • The PR does not break APIs backward compatibility
  • The PR does not break the stable storage backward compatibility

Testing

  • Every function is properly unit tested
  • I have added integration tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • IC endpoints are always tested through the canister_call! macro

@itsyaasir itsyaasir requested review from valeriyr, GraDKh, veeso and F3kilo July 7, 2023 07:35
ufoscout
ufoscout requested changes Jul 10, 2023
View reviewed changes
Copy link
Contributor

@ufoscout ufoscout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the register-evm-agent updated with this changes?

@itsyaasir
Copy link
Contributor Author

Should we change the naming of the crate ?

@itsyaasir itsyaasir requested a review from ufoscout July 11, 2023 13:58
@ufoscout ufoscout merged commit 344ac57 into main Jul 12, 2023
@ufoscout ufoscout deleted the EPROD-424-remove-user-registration-from-emvc branch July 12, 2023 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GraDKh GraDKh GraDKh approved these changes

@blutooth blutooth blutooth approved these changes

@ufoscout ufoscout ufoscout approved these changes

@valeriyr valeriyr Awaiting requested review from valeriyr

@veeso veeso Awaiting requested review from veeso

@F3kilo F3kilo Awaiting requested review from F3kilo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@itsyaasir @ufoscout @blutooth @GraDKh @valeriyr