Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EPROD-1099] fix signature v #214

Merged
merged 13 commits into from
Dec 20, 2024
Merged

[EPROD-1099] fix signature v #214

merged 13 commits into from
Dec 20, 2024

Conversation

ufoscout
Copy link
Contributor

@ufoscout ufoscout commented Dec 19, 2024

Issue ticket

Issue ticket link: <>
https://infinityswap.atlassian.net/browse/EPROD-1099

Checklist before requesting a review

Code conventions

  • I have performed a self-review of my code
  • Every new function is documented
  • Object names are auto explicative

Security

  • The PR does not break APIs backward compatibility
  • The PR does not break the stable storage backward compatibility

Testing

  • Every function is properly unit tested
  • I have added integration tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • IC endpoints are always tested through the canister_call! macro

src/eth-signer/src/ic_sign.rs Outdated Show resolved Hide resolved
src/eth-signer/src/ic_sign.rs Outdated Show resolved Hide resolved
@ufoscout ufoscout requested a review from veeso December 19, 2024 11:19
@ufoscout ufoscout merged commit ae8b8b4 into main Dec 20, 2024
3 checks passed
@ufoscout ufoscout deleted the EPROD-1099_fix_signature_v branch December 20, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants