Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add get_chain_id method #24

Merged
merged 3 commits into from
Jul 12, 2023
Merged

Add get_chain_id method #24

merged 3 commits into from
Jul 12, 2023

Conversation

GraDKh
Copy link
Contributor

@GraDKh GraDKh commented Jul 12, 2023 •
edited
Loading

Issue ticket

Issue ticket link: <>

Checklist before requesting a review

Code conventions

  • I have performed a self-review of my code
  • Every new function is documented
  • Object names are auto explicative

Security

  • The PR does not break APIs backward compatibility
  • The PR does not break the stable storage backward compatibility

Testing

  • Every function is properly unit tested
  • I have added integration tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • IC endpoints are always tested through the canister_call! macro

@GraDKh GraDKh merged commit 28ee16e into main Jul 12, 2023
@GraDKh GraDKh deleted the add_chain_id_to_client branch July 12, 2023 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itsyaasir itsyaasir itsyaasir approved these changes

@ufoscout ufoscout ufoscout approved these changes

@valeriyr valeriyr Awaiting requested review from valeriyr

@veeso veeso Awaiting requested review from veeso

@F3kilo F3kilo Awaiting requested review from F3kilo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GraDKh @ufoscout @itsyaasir