Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Eprod-439] signature verification client #30

Merged
merged 5 commits into from
Jul 18, 2023
Merged

[Eprod-439] signature verification client #30

merged 5 commits into from
Jul 18, 2023

Conversation

ufoscout
Copy link
Contributor

@ufoscout ufoscout commented Jul 18, 2023 •
edited
Loading

Issue ticket

Issue ticket link: https://infinityswap.atlassian.net/browse/EPROD-439

Checklist before requesting a review

Code conventions

  • I have performed a self-review of my code
  • Every new function is documented
  • Object names are auto explicative

Security

  • The PR does not break APIs backward compatibility
  • The PR does not break the stable storage backward compatibility

Testing

  • Every function is properly unit tested
  • I have added integration tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • IC endpoints are always tested through the canister_call! macro

@ufoscout ufoscout merged commit b64031b into main Jul 18, 2023
@ufoscout ufoscout deleted the EPROD-439_signature_verification_client branch July 18, 2023 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veeso veeso veeso approved these changes

@GraDKh GraDKh GraDKh approved these changes

@itsyaasir itsyaasir itsyaasir approved these changes

@F3kilo F3kilo Awaiting requested review from F3kilo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ufoscout @itsyaasir @GraDKh @veeso