upgrade node to v16, and update dependencies #1
Conversation
…he project, because the old version of axios has security vulnerabilities.
There was a problem hiding this comment.
Thanks. @sschiessl-bcp please take a look. Permissions granted.
|
By the way, if need permissions for other repositories (I have added some already), please let me know. |
| @@ -38,7 +41,7 @@ class ComponentA extends React.Component { | |||
| this.state = props.alt.stores.store.getState() | |||
| } | |||
|
|
|||
| componentWillMount() { | |||
| componentDidMount() { | |||
There was a problem hiding this comment.
We are changing here the hook in the React lifecycle. While this is likely ok, we need to be aware that if we encounter strange re-rendering of components this might be a cause of it
There was a problem hiding this comment.
I guess this change is wrong..
There was a problem hiding this comment.
Assuming the intention of componentWillMount has not been abused, componentDidMount is the replacement recommendation
https://reactjs.org/docs/react-component.html#unsafe_componentwillmount
The alternative would be to use UNSAFE_componentWillMount
There was a problem hiding this comment.
I just noticed this is used in test/batching-test.js, so definitely not a blocker for the PR. But, important to keep in mind when we are updating the UI
|
@xiangxn the UI runs ok and as expected with this I assume? |
The impact in componentWillMount will not be too great. The modification here mainly depends on whether the test can be completed after the update. |
|
In addition, I will put the lib directory together for ease of reference. |
upgrade node to v16, and update dependencies