move path expansion to load, fix doc typo, fix test #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Paul,
I was playing with using Elixir 1.9 releases with toml master and ran into a snag where I'd get an error during release assembly if the env var for my toml config path wasn't set in my build environment. Looks like the path expansion needs to happen in load rather than init to avoid that. I went ahead and tweaked that as well as added a missing bracket in the doc example and made a failing test pass while I was in there.
I successfully deployed with this branch via both elixir 1.9 releases and via distillery so there doesn't seem to be any downside to moving the path expansion to the load step.
Thanks!
Adam