Skip to content

Commit

Permalink
🔨 Remove static from internal function
Browse files Browse the repository at this point in the history
During refactoring of `not_null`, the `detail::not_null_to_address`
was relocated from a `static` member function of `not_null` to being
a `detail` function -- though it unintentionally retained the `static`
identifier.

This appears to potentially be confusing MSVC, and is objectively wrong
already since this forces the symbols to have internal linkage. These
modifiers have been removed.
  • Loading branch information
bitwizeshift committed Dec 19, 2020
1 parent 6108ba5 commit fe380f7
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions include/not_null.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -140,10 +140,10 @@ inline namespace bitwizeshift {
/// \param p the pointer-like type
/// \return the underlying raw pointer
template <typename U>
static constexpr auto not_null_to_address(U* p)
constexpr auto not_null_to_address(U* p)
noexcept -> U*;
template <typename Ptr>
static constexpr auto not_null_to_address(const Ptr& p)
constexpr auto not_null_to_address(const Ptr& p)
noexcept -> decltype(::NOT_NULL_NS_IMPL::detail::not_null_to_address(p.operator->()));
/// \}

Expand Down

0 comments on commit fe380f7

Please sign in to comment.