Fixing squid:S00117- Local variable and method parameter names should…

… comply with a naming convention.
bizcluster · May 19, 2016 · 5a43322 · 5a43322
1 parent 9d3aaf4
commit 5a43322
Show file tree

Hide file tree

Showing 8 changed files with 19 additions and 19 deletions.
diff --git a/app/src/main/java/bf/io/openshop/utils/Analytics.java b/app/src/main/java/bf/io/openshop/utils/Analytics.java
@@ -196,9 +196,9 @@ public static void logProductView(long remoteId, String name) {
      *
      * @param remoteId       remote id of the viewed product.
      * @param name           name of the viewed product.
-     * @param discount_price product price.
+     * @param discountPrice product price.
      */
-    public static void logAddProductToCart(long remoteId, String name, double discount_price) {
+    public static void logAddProductToCart(long remoteId, String name, double discountPrice) {
         // FB facebookLogger
         Bundle parameters = new Bundle();
         parameters.putString(AppEventsConstants.EVENT_PARAM_CONTENT_TYPE, "product");
@@ -210,7 +210,7 @@ public static void logAddProductToCart(long remoteId, String name, double discou
         Map<String, String> event = new HitBuilders.EventBuilder()
                 .setCategory("ADDED_TO_CART")
                 .setAction("ADDED_TO_CART")
-                .setLabel("ADDED TO CART" + " product id: " + remoteId + " product name: " + name + " price: " + discount_price)
+                .setLabel("ADDED TO CART" + " product id: " + remoteId + " product name: " + name + " price: " + discountPrice)
                 .build();
         sendEventToAppTrackers(event);
     }

diff --git a/app/src/main/java/bf/io/openshop/utils/EndlessRecyclerScrollListener.java b/app/src/main/java/bf/io/openshop/utils/EndlessRecyclerScrollListener.java
@@ -104,8 +104,8 @@ public void resetLoading() {
 
     /**
      * Method indicates that end has been reached.
-     * @param current_page total number of loading calls.
+     * @param currentPage total number of loading calls.
      */
-    public abstract void onLoadMore(int current_page);
+    public abstract void onLoadMore(int currentPage);
 
 }
diff --git a/app/src/main/java/bf/io/openshop/utils/MyGcmListenerService.java b/app/src/main/java/bf/io/openshop/utils/MyGcmListenerService.java
@@ -137,10 +137,10 @@ private void sendNotification(Bundle extras) {
             notificationIntent.putExtra(EndPoints.NOTIFICATION_TITLE, title);
         }
 
-        String utm_source = "utm_source=API";
-        String utm_medium = "utm_medium=notification";
-        String utm_campaign = "utm_campaign=" + title;
-        String utm = utm_source + "&" + utm_medium + "&" + utm_campaign;
+        String utmSource = "utm_source=API";
+        String utmMedium = "utm_medium=notification";
+        String utmCampaign = "utm_campaign=" + title;
+        String utm = utmSource + "&" + utmMedium + "&" + utmCampaign;
         notificationIntent.putExtra(EndPoints.NOTIFICATION_UTM, utm);
         // Create notification
         PendingIntent contentIntent = PendingIntent.getActivity(this, 0, notificationIntent, PendingIntent.FLAG_UPDATE_CURRENT);

diff --git a/app/src/main/java/bf/io/openshop/utils/MyRegistrationIntentService.java b/app/src/main/java/bf/io/openshop/utils/MyRegistrationIntentService.java
@@ -116,10 +116,10 @@ public void onErrorResponse(VolleyError error) {
             if (shop != null) {
                 String url = String.format(EndPoints.REGISTER_NOTIFICATION, shop.getId());
                 JsonRequest req;
-                User ActiveUser = SettingsMy.getActiveUser();
-                if (ActiveUser != null) {
+                User activeUser = SettingsMy.getActiveUser();
+                if (activeUser != null) {
                     Timber.d("GCM registration send: authorized");
-                    req = new JsonRequest(Request.Method.POST, url, requestPost, future, errorListener, null, ActiveUser.getAccessToken());
+                    req = new JsonRequest(Request.Method.POST, url, requestPost, future, errorListener, null, activeUser.getAccessToken());
                 } else {
                     Timber.d("GCM registration send: non-authorized");
                     req = new JsonRequest(Request.Method.POST, url, requestPost, future, errorListener);

diff --git a/app/src/main/java/bf/io/openshop/ux/adapters/SortSpinnerAdapter.java b/app/src/main/java/bf/io/openshop/ux/adapters/SortSpinnerAdapter.java
@@ -32,10 +32,10 @@ public SortSpinnerAdapter(Activity activity) {
         sortItemList.add(newest);
         SortItem popularity = new SortItem("popularity", activity.getString(R.string.Recommended));
         sortItemList.add(popularity);
-        SortItem price_DESC = new SortItem("price_DESC", activity.getString(R.string.Highest_price));
-        sortItemList.add(price_DESC);
-        SortItem price_ASC = new SortItem("price_ASC", activity.getString(R.string.Lowest_price));
-        sortItemList.add(price_ASC);
+        SortItem priceDesc = new SortItem("price_DESC", activity.getString(R.string.Highest_price));
+        sortItemList.add(priceDesc);
+        SortItem priceAsc = new SortItem("price_ASC", activity.getString(R.string.Lowest_price));
+        sortItemList.add(priceAsc);
 
     }
 

diff --git a/app/src/main/java/bf/io/openshop/ux/fragments/BannersFragment.java b/app/src/main/java/bf/io/openshop/ux/fragments/BannersFragment.java
@@ -112,7 +112,7 @@ public void onBannerSelected(Banner banner) {
         bannersRecycler.setAdapter(bannersRecyclerAdapter);
         endlessRecyclerScrollListener = (new EndlessRecyclerScrollListener(layoutManager) {
             @Override
-            public void onLoadMore(int current_page) {
+            public void onLoadMore(int currentPage) {
                 if (bannersMetadata != null && bannersMetadata.getLinks() != null && bannersMetadata.getLinks().getNext() != null) {
                     loadBanners(bannersMetadata.getLinks().getNext());
                 } else {

diff --git a/app/src/main/java/bf/io/openshop/ux/fragments/CategoryFragment.java b/app/src/main/java/bf/io/openshop/ux/fragments/CategoryFragment.java
@@ -277,7 +277,7 @@ public View makeView() {
         productsRecycler.setLayoutManager(productsRecyclerLayoutManager);
         endlessRecyclerScrollListener = new EndlessRecyclerScrollListener(productsRecyclerLayoutManager) {
             @Override
-            public void onLoadMore(int current_page) {
+            public void onLoadMore(int currentPage) {
                 Timber.e("Load more");
                 if (productsMetadata != null && productsMetadata.getLinks() != null && productsMetadata.getLinks().getNext() != null) {
                     getProducts(productsMetadata.getLinks().getNext());

diff --git a/app/src/main/java/bf/io/openshop/ux/fragments/OrdersHistoryFragment.java b/app/src/main/java/bf/io/openshop/ux/fragments/OrdersHistoryFragment.java
@@ -102,7 +102,7 @@ public void onOrderSelected(View v, Order order) {
 
         endlessRecyclerScrollListener = new EndlessRecyclerScrollListener(layoutManager) {
             @Override
-            public void onLoadMore(int current_page) {
+            public void onLoadMore(int currentPage) {
                 if (ordersMetadata != null && ordersMetadata.getLinks() != null && ordersMetadata.getLinks().getNext() != null) {
                     loadOrders(ordersMetadata.getLinks().getNext());
                 } else {