Use gettext for translation support and add french translation #64
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I'm currently working on French support and this second PR add
gettext
usage to allow warning and suggestion messages translation. My modifications:dgettext()
to translate warning and suggestion messages from custom text domainZxcvbnPhp
. Note:TimeEstimator::displayTime()
method was simplified usingdngettext()
that handle plural forms.Locales
directory to store translation stuffZxcvbnPhp
text domain toLocales
directory inZxcvbn
class constructorextract_messages.sh
script that handle messages extractions usingxgettext
and generate/updateLocales/zxcvbn-php.pot
fileLocales/fr_FR.UTF8
directoryThis solution permit to easily integrate this library in PHP application that already use gettext for translation. Other applications just have to set locale by setting
LANGUAGE
environment variable or usingsetlocale()
function.