Merge pull request kubevirt#1283 from davidvossel/enable-race-detect

Turn on -race for test suite

hack/build-go.sh

@@ -43,7 +43,7 @@ if [ $# -eq 0 ]; then
     if [ "${target}" = "test" ]; then
         (
             cd ${KUBEVIRT_DIR}/pkg
-            go ${target} -v ./...
+            go ${target} -v -race ./...
         )
     else
         (

pkg/virt-handler/device-manager/device_controller_test.go

@@ -63,22 +63,24 @@ var _ = Describe("Device Controller", func() {
 			By(fmt.Sprintf("Device Path: %s", devicePath))
 
 			timeout := make(chan struct{})
-
-			go func() {
+			errChan := make(chan error)
+			go func(devicePath string) {
 				time.Sleep(1 * time.Second)
 
 				fileObj, err := os.Create(devicePath)
-				Expect(err).ToNot(HaveOccurred())
 				fileObj.Close()
-			}()
+				errChan <- err
+			}(devicePath)
 
-			go func() {
+			go func(timeout chan struct{}) {
 				time.Sleep(5 * time.Second)
 				close(timeout)
-			}()
+			}(timeout)
 
-			err := deviceController.waitForPath(devicePath, timeout)
+			err := <-errChan
+			Expect(err).ToNot(HaveOccurred())
 
+			err = deviceController.waitForPath(devicePath, timeout)
 			Expect(err).ToNot(HaveOccurred())
 		})
 	})

pkg/virt-launcher/monitor_test.go

@@ -24,6 +24,7 @@ import (
 	"os"
 	"os/exec"
 	"strings"
+	"sync"
 	"syscall"
 	"time"
 
@@ -36,6 +37,7 @@ import (
 var _ = Describe("VirtLauncher", func() {
 	var mon *monitor
 	var cmd *exec.Cmd
+	var cmdLock sync.Mutex
 
 	uuid := "123-123-123-123"
 
@@ -52,6 +54,9 @@ var _ = Describe("VirtLauncher", func() {
 	processStarted := false
 
 	StartProcess := func() {
+		cmdLock.Lock()
+		defer cmdLock.Unlock()
+
 		cmd = exec.Command(processPath, "--uuid", uuid)
 		err := cmd.Start()
 		Expect(err).ToNot(HaveOccurred())
@@ -63,11 +68,17 @@ var _ = Describe("VirtLauncher", func() {
 	}
 
 	StopProcess := func() {
+		cmdLock.Lock()
+		defer cmdLock.Unlock()
+
 		cmd.Process.Kill()
 		processStarted = false
 	}
 
 	CleanupProcess := func() {
+		cmdLock.Lock()
+		defer cmdLock.Unlock()
+
 		cmd.Wait()
 	}
 
@@ -114,6 +125,8 @@ var _ = Describe("VirtLauncher", func() {
 	AfterEach(func() {
 		os.RemoveAll(tmpDir)
 		if processStarted == true {
+			cmdLock.Lock()
+			defer cmdLock.Unlock()
 			cmd.Process.Kill()
 		}
 		processStarted = false