network: rename getNetworkClass

There are no classes in Go, so this function cannot return one. In fact, it returns a new instance of NetworkInterface. This commit drops a confusing comment, as the function does not get a "suitable network interface". It always returns a PodInterface instance. Signed-off-by: Dan Kenigsberg <[email protected]>
bk201 · Jan 19, 2021 · a43b260 · a43b260
1 parent 2deeb90
commit a43b260
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/pkg/virt-launcher/virtwrap/network/network.go b/pkg/virt-launcher/virtwrap/network/network.go
@@ -38,7 +38,7 @@ const primaryPodInterfaceName = "eth0"
 
 var interfaceCacheFile = "/proc/%s/root/var/run/kubevirt-private/interface-cache-%s.json"
 var vifCacheFile = "/proc/%s/root/var/run/kubevirt-private/vif-cache-%s.json"
-var NetworkInterfaceFactory = getNetworkClass
+var NetworkInterfaceFactory = getNewNetworkInterface
 
 type PodCacheInterface struct {
 	Iface  *v1.Interface `json:"iface,omitempty"`
@@ -134,8 +134,7 @@ func SetupNetworkInterfacesPhase2(vmi *v1.VirtualMachineInstance, domain *api.Do
 	return nil
 }
 
-// a factory to get suitable network interface
-func getNetworkClass(network *v1.Network) (NetworkInterface, error) {
+func getNewNetworkInterface(network *v1.Network) (NetworkInterface, error) {
 	if network.Pod != nil || network.Multus != nil {
 		return new(PodInterface), nil
 	}

diff --git a/pkg/virt-launcher/virtwrap/network/network_test.go b/pkg/virt-launcher/virtwrap/network/network_test.go
@@ -40,7 +40,7 @@ var _ = Describe("Network", func() {
 		mockNetworkInterface = NewMockNetworkInterface(ctrl)
 	})
 	AfterEach(func() {
-		NetworkInterfaceFactory = getNetworkClass
+		NetworkInterfaceFactory = getNewNetworkInterface
 	})
 
 	Context("interface configuration", func() {