Allow overriding serializers

bk203 · Jun 30, 2014 · 03e80ca · 03e80ca
1 parent 2776be3
commit 03e80ca
Show file tree

Hide file tree

Showing 5 changed files with 63 additions and 3 deletions.
diff --git a/DependencyInjection/BazingaHateoasExtension.php b/DependencyInjection/BazingaHateoasExtension.php
@@ -14,6 +14,7 @@
 use Symfony\Component\DependencyInjection\Loader\XmlFileLoader;
 use Symfony\Component\DependencyInjection\Alias;
 use Symfony\Component\DependencyInjection\ContainerBuilder;
+use Symfony\Component\DependencyInjection\Reference;
 use Symfony\Component\Config\FileLocator;
 
 /**
@@ -51,5 +52,13 @@ public function load(array $configs, ContainerBuilder $container)
                 new Alias($config['metadata']['cache'], false)
             );
         }
+
+        $container
+            ->getDefinition('hateoas.event_subscriber.json')
+            ->replaceArgument(0, new Reference($config['serializer']['json']));
+
+        $container
+            ->getDefinition('hateoas.event_subscriber.xml')
+            ->replaceArgument(0, new Reference($config['serializer']['xml']));
     }
 }
diff --git a/DependencyInjection/Configuration.php b/DependencyInjection/Configuration.php
@@ -42,6 +42,13 @@ public function getConfigTreeBuilder()
                     ->end()
                 ->end()
             ->end()
+            ->arrayNode('serializer')
+                ->addDefaultsIfNotSet()
+                ->children()
+                    ->scalarNode('json')->defaultValue('hateoas.serializer.json_hal')->end()
+                    ->scalarNode('xml')->defaultValue('hateoas.serializer.xml')->end()
+                ->end()
+            ->end()
         ;
 
         return $treeBuilder;

diff --git a/Resources/config/serializer.xml b/Resources/config/serializer.xml
@@ -72,14 +72,14 @@
         <!-- Subscribers -->
         <service id="hateoas.event_subscriber.xml" class="%hateoas.event_subscriber.xml.class%">
             <tag name="jms_serializer.event_subscriber" />
-            <argument type="service" id="hateoas.serializer.xml" />
+            <argument /> <!-- xml serializer -->
             <argument type="service" id="hateoas.links_factory" />
             <argument type="service" id="hateoas.embeds_factory" />
         </service>
 
         <service id="hateoas.event_subscriber.json" class="%hateoas.event_subscriber.json.class%">
             <tag name="jms_serializer.event_subscriber" />
-            <argument type="service" id="hateoas.serializer.json_hal" />
+            <argument /> <!-- json serializer -->
             <argument type="service" id="hateoas.links_factory" />
             <argument type="service" id="hateoas.embeds_factory" />
             <argument type="service" id="hateoas.inline_deferrer.embeds" />

diff --git a/Tests/DependencyInjection/BazingaHateoasExtensionTest.php b/Tests/DependencyInjection/BazingaHateoasExtensionTest.php
@@ -68,6 +68,30 @@ public function testLoadUrlGenerator()
         $this->assertInstanceOf($urlGeneratorClass, $urlGenerator2);
     }
 
+    public function testLoadSerializer()
+    {
+        $class = 'Bazinga\Bundle\HateoasBundle\Tests\Fixtures\JsonSerializer';
+        $container = $this->getContainerForConfig(array('bazinga_hateoas' => array('serializer' => array('json' => 'custom_serializer'))));
+        $container->setDefinition('custom_serializer', new Definition($class));
+        $container->compile();
+
+        $jsonListener = $container->get('hateoas.event_subscriber.json');
+
+        $reflClass = new \ReflectionClass($jsonListener);
+        $reflProp = $reflClass->getProperty('jsonSerializer');
+        $reflProp->setAccessible(true);
+
+        $this->assertInstanceOf($class, $reflProp->getValue($jsonListener));
+
+        $xmlListener = $container->get('hateoas.event_subscriber.xml');
+
+        $reflClass = new \ReflectionClass($xmlListener);
+        $reflProp = $reflClass->getProperty('xmlSerializer');
+        $reflProp->setAccessible(true);
+
+        $this->assertInstanceOf('Hateoas\Serializer\XmlSerializer', $reflProp->getValue($xmlListener));
+    }
+
     private function clearTempDir()
     {
         // clear temporary directory
@@ -127,8 +151,10 @@ private function getContainerForConfig(array $configs, KernelInterface $kernel =
         $container->setParameter('foo', 'bar');
 
         foreach ($extensions as $extension) {
+            $extensionConfig = isset($configs[$extension->getAlias()]) ? $configs[$extension->getAlias()] : array();
+
             $container->registerExtension($extension);
-            $extension->load($configs, $container);
+            $extension->load(array($extension->getAlias() => $extensionConfig), $container);
         }
 
         foreach ($bundles as $bundle) {

diff --git a/Tests/Fixtures/JsonSerializer.php b/Tests/Fixtures/JsonSerializer.php
@@ -0,0 +1,18 @@
+<?php
+
+namespace Bazinga\Bundle\HateoasBundle\Tests\Fixtures;
+
+use Hateoas\Serializer\JsonSerializerInterface;
+use JMS\Serializer\JsonSerializationVisitor;
+use JMS\Serializer\SerializationContext;
+
+class JsonSerializer implements JsonSerializerInterface
+{
+    public function serializeLinks(array $links, JsonSerializationVisitor $visitor, SerializationContext $context)
+    {
+    }
+
+    public function serializeEmbeddeds(array $embeddeds, JsonSerializationVisitor $visitor, SerializationContext $context)
+    {
+    }
+}