Switch to phpunit 8 to fix deprecation warnings in tests

bk203 · Nov 30, 2019 · d2bf57f · d2bf57f
1 parent f6211df
commit d2bf57f
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 13 deletions.
diff --git a/Tests/DependencyInjection/BazingaHateoasExtensionTest.php b/Tests/DependencyInjection/BazingaHateoasExtensionTest.php
@@ -23,12 +23,12 @@
 
 class BazingaHateoasExtensionTest extends TestCase
 {
-    public function setUp()
+    public function setUp(): void
     {
         $this->clearTempDir();
     }
 
-    public function tearDown()
+    public function tearDown(): void
     {
         $this->clearTempDir();
     }
@@ -69,11 +69,10 @@ public function testRelationProviderPassInvalidProvider()
         $this->assertCount(3, $arguments[0]);
     }
 
-    /**
-     * @expectedException InvalidArgumentException
-     */
     public function testRelationProviderPass()
     {
+        $this->expectException(InvalidArgumentException::class);
+
         $container = $this->getContainerForConfig([[]]);
         $definition = $container->register('invalid_relation_provider', 'stdClass');
         $definition->addTag('hateoas.relation_provider');
@@ -125,22 +124,20 @@ public function testLoadSerializer()
         $this->assertInstanceOf('Hateoas\Serializer\XmlSerializer', $reflProp->getValue($xmlListener));
     }
 
-    /**
-     * @expectedException Symfony\Component\DependencyInjection\Exception\InvalidArgumentException
-     */
     public function testNotLoadingTwigHelper()
     {
+        $this->expectException(InvalidArgumentException::class);
+
         $container = $this->getContainerForConfig(['bazinga_hateoas' => ['twig_extension' => ['enabled' => false]]]);
         $container->findDefinition('hateoas.twig.link');
         $container->compile();
     }
 
-    /**
-     * @expectedException Symfony\Component\DependencyInjection\Exception\InvalidArgumentException
-     * @expectedExceptionMessage Service invalid_configuration_extension tagged with hateoas.configuration_extension must implement Hateoas\Configuration\Metadata\ConfigurationExtensionInterface
-     */
     public function testLoadInvalidConfigurationExtension()
     {
+        $this->expectException(InvalidArgumentException::class);
+        $this->expectExceptionMessage('Service invalid_configuration_extension tagged with hateoas.configuration_extension must implement Hateoas\Configuration\Metadata\ConfigurationExtensionInterface');
+
         $container = $this->getContainerForConfig([[]]);
         $container
             ->setDefinition(

diff --git a/composer.json b/composer.json
@@ -19,7 +19,7 @@
     },
     "require-dev": {
         "twig/twig": "~1.12|~2.0",
-        "phpunit/phpunit": "^7",
+        "phpunit/phpunit": "^8.4",
         "symfony/stopwatch": "~3.0 || ~4.0",
         "doctrine/coding-standard": "^5.0"
     },