Skip to content

Commit

Permalink
Move advanced column family options to advanced_options.h
Browse files Browse the repository at this point in the history
Summary:
For the sake of making our options simpler, we should keep options.h as simple as possible and move more advanced/less common options to advaned_options.h

I started with ColumnFamilyOptions and also did some re-ordering

I have moved all ColumnFamilyOptions to advanced_options.h and only left these options in options.h

```
const Comparator* comparator = BytewiseComparator();
std::shared_ptr<MergeOperator> merge_operator = nullptr;
const CompactionFilter* compaction_filter = nullptr;
std::shared_ptr<CompactionFilterFactory> compaction_filter_factory = nullptr;
size_t write_buffer_size = 64 << 20;
CompressionType compression;
int level0_file_num_compaction_trigger = 4;
bool disable_auto_compactions = false;
```
Please feel free to comment on specific options if you think they should be advanced or should not be
Closes facebook#1847

Differential Revision: D4519996

Pulled By: IslamAbdelRahman

fbshipit-source-id: abebd9a
  • Loading branch information
IslamAbdelRahman authored and facebook-github-bot committed Feb 28, 2017
1 parent 2ca2059 commit 08864df
Show file tree
Hide file tree
Showing 5 changed files with 720 additions and 673 deletions.
Loading

0 comments on commit 08864df

Please sign in to comment.