Skip to content

Commit

Permalink
remove incorrect assert in GetUniqueIdFromFile (facebook#5102)
Browse files Browse the repository at this point in the history
Summary:
User report has shown that sometimes `BlockBasedTable::SetupCacheKeyPrefix` would assert when trying to generate an id from the file. The actual cause seems to be hardware related but we might be better off without the incorrect assertion
See T42178927 for more information
Pull Request resolved: facebook#5102

Differential Revision: D14604677

Pulled By: miasantreble

fbshipit-source-id: fcb09207ebdc4fa66e941afbc0523d84797e7ad7
  • Loading branch information
miasantreble authored and facebook-github-bot committed Mar 26, 2019
1 parent 48e7eff commit 3c5eed5
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion env/io_posix.cc
Original file line number Diff line number Diff line change
Expand Up @@ -265,7 +265,6 @@ size_t PosixHelper::GetUniqueIdFromFile(int fd, char* id, size_t max_size) {

struct stat buf;
int result = fstat(fd, &buf);
assert(result != -1);
if (result == -1) {
return 0;
}
Expand Down

0 comments on commit 3c5eed5

Please sign in to comment.