Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: YAML data source #266

Merged
merged 6 commits into from
Dec 7, 2024
Merged

feat: YAML data source #266

merged 6 commits into from
Dec 7, 2024

Conversation

traut
Copy link
Member

@traut traut commented Nov 29, 2024 •
edited
Loading

Adds yaml data source, similar to json source

In addition, some small documentation tweaks

dobarx
dobarx approved these changes Nov 30, 2024
View reviewed changes
Copy link
Contributor

@dobarx dobarx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍
Just a couple of questions on small things.

internal/builtin/data_yaml.go Outdated Show resolved Hide resolved
internal/builtin/data_yaml.go Show resolved Hide resolved
@traut traut merged commit cb3ceb4 into main Dec 7, 2024
8 checks passed
@traut traut deleted the data-source-yaml branch December 7, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dobarx dobarx dobarx approved these changes

@Andrew-Morozko Andrew-Morozko Awaiting requested review from Andrew-Morozko

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@traut @dobarx