Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow to set json encoder #23

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

allow to set json encoder #23

wants to merge 3 commits into from

Conversation

AlexKovalevych
Copy link

No description provided.

@AlexKovalevych AlexKovalevych mentioned this pull request Jan 15, 2019
Closed
@bgmarx
Copy link
Contributor

bgmarx commented Jan 28, 2019

Thanks for the PR! I'll look at it this week.

scrogson
scrogson suggested changes Apr 9, 2019
View reviewed changes
Copy link
Contributor

@scrogson scrogson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Can you please rebase your changes on master?

lib/plug/logger_json.ex Outdated
@@ -21,7 +21,13 @@ defmodule Plug.LoggerJSON do
}
```

To use it, just plug it into the desired module.
To use it, set json_encoder parameter in you config:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/you/your

@4xposed
Copy link

4xposed commented Aug 12, 2019 •
edited
Loading

it would be nice if this PR could be merged as Poison is not the de-facto json encoder/decoder anymore.

@AlexKovalevych
Copy link
Author

Ok, i'll fix it on this week

@diogommartins
Copy link

Hey guys, I'm interested in using plug_logger_json and using Jason is a must for me. Having this Pull Request merged would make it possible, but I'm assuming it's currently stalled. @scrogson are you still interested in it? Can I join and make the changes myself ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scrogson scrogson scrogson requested changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AlexKovalevych @bgmarx @4xposed @diogommartins @scrogson