airo: Reorder tests, check bounds before element

Test whether index is within bounds before reading the element Signed-off-by: Roel Kluin <[email protected]> Signed-off-by: John W. Linville <[email protected]>
blinkosm · Oct 27, 2009 · 30bd572 · 30bd572
1 parent 9b1ce52
commit 30bd572
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/drivers/net/wireless/airo.c b/drivers/net/wireless/airo.c
@@ -4790,9 +4790,8 @@ static int proc_stats_rid_open( struct inode *inode,
 static int get_dec_u16( char *buffer, int *start, int limit ) {
 	u16 value;
 	int valid = 0;
-	for( value = 0; buffer[*start] >= '0' &&
-		     buffer[*start] <= '9' &&
-		     *start < limit; (*start)++ ) {
+	for (value = 0; *start < limit && buffer[*start] >= '0' &&
+			buffer[*start] <= '9'; (*start)++) {
 		valid = 1;
 		value *= 10;
 		value += buffer[*start] - '0';