PIP-119: Enable consistent hashing by default on KeyShared subscripti…

…ons dispatcher (apache#13352) * PIP-119: Enable consistent hashing by default on KeyShared subscriptions dispatcher * Fixed formatting Co-authored-by: Matteo Merli <[email protected]>
blitznihar · Jan 25, 2022 · 5b39913 · 5b39913
1 parent c20d55d
commit 5b39913
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/conf/broker.conf b/conf/broker.conf
@@ -226,7 +226,7 @@ subscriptionTypesEnabled=Exclusive,Shared,Failover,Key_Shared
 
 # On KeyShared subscriptions, with default AUTO_SPLIT mode, use splitting ranges or
 # consistent hashing to reassign keys to new consumers
-subscriptionKeySharedUseConsistentHashing=false
+subscriptionKeySharedUseConsistentHashing=true
 
 # On KeyShared subscriptions, number of points in the consistent-hashing ring.
 # The higher the number, the more equal the assignment of keys to consumers

diff --git a/conf/standalone.conf b/conf/standalone.conf
@@ -138,7 +138,7 @@ subscriptionRedeliveryTrackerEnabled=true
 
 # On KeyShared subscriptions, with default AUTO_SPLIT mode, use splitting ranges or
 # consistent hashing to reassign keys to new consumers
-subscriptionKeySharedUseConsistentHashing=false
+subscriptionKeySharedUseConsistentHashing=true
 
 # On KeyShared subscriptions, number of points in the consistent-hashing ring.
 # The higher the number, the more equal the assignment of keys to consumers

diff --git a/deployment/terraform-ansible/templates/broker.conf b/deployment/terraform-ansible/templates/broker.conf
@@ -162,7 +162,7 @@ subscriptionKeySharedEnable=true
 
 # On KeyShared subscriptions, with default AUTO_SPLIT mode, use splitting ranges or
 # consistent hashing to reassign keys to new consumers
-subscriptionKeySharedUseConsistentHashing=false
+subscriptionKeySharedUseConsistentHashing=true
 
 # On KeyShared subscriptions, number of points in the consistent-hashing ring.
 # The higher the number, the more equal the assignment of keys to consumers

diff --git a/pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java b/pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java
@@ -570,8 +570,8 @@ public class ServiceConfiguration implements PulsarConfiguration {
 
     @FieldContext(category = CATEGORY_POLICIES,
             doc = "On KeyShared subscriptions, with default AUTO_SPLIT mode, use splitting ranges or "
-                    + "consistent hashing to reassign keys to new consumers")
-    private boolean subscriptionKeySharedUseConsistentHashing = false;
+                    + "consistent hashing to reassign keys to new consumers (default is consistent hashing)")
+    private boolean subscriptionKeySharedUseConsistentHashing = true;
 
     @FieldContext(
         category = CATEGORY_POLICIES,