Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Utils create a dictionary decoder #35

Merged
merged 9 commits into from
Jul 19, 2024
Merged

Utils create a dictionary decoder #35

merged 9 commits into from
Jul 19, 2024

Conversation

Nytro1O1
Copy link
Collaborator

Summary

Closes #

Test Plan

@bliutech bliutech linked an issue Jul 18, 2024 that may be closed by this pull request
Utils: Write a Dictionary Decoder #16
Closed
3 tasks
@bliutech bliutech self-requested a review July 18, 2024 02:51
bliutech
bliutech requested changes Jul 18, 2024
View reviewed changes
Copy link
Owner

@bliutech bliutech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a couple of comments. It looks like you forgot to pull so this branch is out of date with changes from main. Can you merge main into this branch to get this updated? This will reduce the diff slightly. May run into merge conflicts so be cautious.

utils/coding.py Outdated Show resolved Hide resolved
utils/coding.py Show resolved Hide resolved
bliutech
bliutech requested changes Jul 18, 2024
View reviewed changes
Copy link
Owner

@bliutech bliutech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more comment. :D

tests/test_coding.py Outdated Show resolved Hide resolved
@Nytro1O1 Nytro1O1 closed this Jul 19, 2024
@Nytro1O1 Nytro1O1 reopened this Jul 19, 2024
@bliutech bliutech self-requested a review July 19, 2024 00:43
bliutech
bliutech approved these changes Jul 19, 2024
View reviewed changes
Copy link
Owner

@bliutech bliutech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😄

@bliutech bliutech merged commit 8d4e845 into main Jul 19, 2024
@bliutech bliutech deleted the Utils-create-a-dictionary-decoder branch July 19, 2024 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bliutech bliutech bliutech approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Utils: Write a Dictionary Decoder
2 participants
@Nytro1O1 @bliutech