Test #1575
Annotations
1 error and 31 warnings
integrationTest (macos-latest)
Process completed with exit code 1.
|
integrationTest (macos-latest):
src/Blockcore/NBitcoin/Crypto/Hashes.cs#L29
'SHA256Managed' is obsolete: 'Derived cryptographic types are obsolete. Use the Create method on the base type instead.' (https://aka.ms/dotnet-warnings/SYSLIB0021)
|
integrationTest (macos-latest):
src/Blockcore/NBitcoin/Bloom.cs#L191
XML comment on 'Bloom.GetCompressedBloom()' has a paramref tag for 'maxSize', but there is no parameter by that name
|
integrationTest (macos-latest):
src/Blockcore/AsyncWork/AsyncLoop.cs#L17
Provide an overridable implementation of Dispose(bool) on 'AsyncLoop' or mark the type as sealed. A call to Dispose(false) should only clean up native resources. A call to Dispose(true) should clean up both managed and native resources. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063)
|
integrationTest (macos-latest):
src/Blockcore/NBitcoin/BitcoinStream.cs#L22
Provide an overridable implementation of Dispose(bool) on 'Scope' or mark the type as sealed. A call to Dispose(false) should only clean up native resources. A call to Dispose(true) should clean up both managed and native resources. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063)
|
integrationTest (macos-latest):
src/Blockcore/Consensus/Chain/ChainRepository.cs#L22
Provide an overridable implementation of Dispose(bool) on 'ChainRepository' or mark the type as sealed. A call to Dispose(false) should only clean up native resources. A call to Dispose(true) should clean up both managed and native resources. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063)
|
integrationTest (macos-latest):
src/Blockcore/Consensus/ConsensusManager.cs#L29
Provide an overridable implementation of Dispose(bool) on 'ConsensusManager' or mark the type as sealed. A call to Dispose(false) should only clean up native resources. A call to Dispose(true) should clean up both managed and native resources. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063)
|
integrationTest (macos-latest):
src/Blockcore/Consensus/ConsensusRuleEngine.cs#L112
Ensure that 'ConsensusRuleEngine.Dispose' is declared as public and sealed (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063)
|
integrationTest (macos-latest):
src/Blockcore/Consensus/ConsensusRuleEngine.cs#L22
Provide an overridable implementation of Dispose(bool) on 'ConsensusRuleEngine' or mark the type as sealed. A call to Dispose(false) should only clean up native resources. A call to Dispose(true) should clean up both managed and native resources. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063)
|
integrationTest (macos-latest):
src/Blockcore/Consensus/FinalizedBlockInfoRepository.cs#L47
Provide an overridable implementation of Dispose(bool) on 'FinalizedBlockInfoRepository' or mark the type as sealed. A call to Dispose(false) should only clean up native resources. A call to Dispose(true) should clean up both managed and native resources. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063)
|
integrationTest (macos-latest):
src/Blockcore/Consensus/ScriptInfo/Script.cs#L382
Move pinvokes to native methods class (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1060)
|
integrationTest (ubuntu-latest)
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
integrationTest (ubuntu-latest):
src/Blockcore/NBitcoin/Crypto/Hashes.cs#L29
'SHA256Managed' is obsolete: 'Derived cryptographic types are obsolete. Use the Create method on the base type instead.' (https://aka.ms/dotnet-warnings/SYSLIB0021)
|
integrationTest (ubuntu-latest):
src/Blockcore/NBitcoin/Bloom.cs#L191
XML comment on 'Bloom.GetCompressedBloom()' has a paramref tag for 'maxSize', but there is no parameter by that name
|
integrationTest (ubuntu-latest):
src/Blockcore/AsyncWork/AsyncLoop.cs#L17
Provide an overridable implementation of Dispose(bool) on 'AsyncLoop' or mark the type as sealed. A call to Dispose(false) should only clean up native resources. A call to Dispose(true) should clean up both managed and native resources. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063)
|
integrationTest (ubuntu-latest):
src/Blockcore/NBitcoin/BitcoinStream.cs#L22
Provide an overridable implementation of Dispose(bool) on 'Scope' or mark the type as sealed. A call to Dispose(false) should only clean up native resources. A call to Dispose(true) should clean up both managed and native resources. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063)
|
integrationTest (ubuntu-latest):
src/Blockcore/P2P/Peer/NetworkPeer.cs#L103
Provide an overridable implementation of Dispose(bool) on 'NetworkPeer' or mark the type as sealed. A call to Dispose(false) should only clean up native resources. A call to Dispose(true) should clean up both managed and native resources. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063)
|
integrationTest (ubuntu-latest):
src/Blockcore/P2P/Peer/NetworkPeerConnection.cs#L24
Provide an overridable implementation of Dispose(bool) on 'NetworkPeerConnection' or mark the type as sealed. A call to Dispose(false) should only clean up native resources. A call to Dispose(true) should clean up both managed and native resources. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063)
|
integrationTest (ubuntu-latest):
src/Blockcore/P2P/Peer/NetworkPeerDisposer.cs#L28
Provide an overridable implementation of Dispose(bool) on 'NetworkPeerDisposer' or mark the type as sealed. A call to Dispose(false) should only clean up native resources. A call to Dispose(true) should clean up both managed and native resources. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063)
|
integrationTest (ubuntu-latest):
src/Blockcore/P2P/Peer/NetworkPeerListener.cs#L13
Provide an overridable implementation of Dispose(bool) on 'NetworkPeerListener' or mark the type as sealed. A call to Dispose(false) should only clean up native resources. A call to Dispose(true) should clean up both managed and native resources. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063)
|
integrationTest (ubuntu-latest):
src/Blockcore/P2P/Peer/NetworkPeerServer.cs#L20
Provide an overridable implementation of Dispose(bool) on 'NetworkPeerServer' or mark the type as sealed. A call to Dispose(false) should only clean up native resources. A call to Dispose(true) should clean up both managed and native resources. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063)
|
integrationTest (ubuntu-latest):
src/Blockcore/P2P/PeerConnector.cs#L45
Provide an overridable implementation of Dispose(bool) on 'PeerConnector' or mark the type as sealed. A call to Dispose(false) should only clean up native resources. A call to Dispose(true) should clean up both managed and native resources. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063)
|
integrationTest (windows-latest):
src/Blockcore/NBitcoin/Crypto/Hashes.cs#L29
'SHA256Managed' is obsolete: 'Derived cryptographic types are obsolete. Use the Create method on the base type instead.' (https://aka.ms/dotnet-warnings/SYSLIB0021)
|
integrationTest (windows-latest):
src/Blockcore/NBitcoin/Bloom.cs#L191
XML comment on 'Bloom.GetCompressedBloom()' has a paramref tag for 'maxSize', but there is no parameter by that name
|
integrationTest (windows-latest):
src/Blockcore/AsyncWork/AsyncLoop.cs#L17
Provide an overridable implementation of Dispose(bool) on 'AsyncLoop' or mark the type as sealed. A call to Dispose(false) should only clean up native resources. A call to Dispose(true) should clean up both managed and native resources. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063)
|
integrationTest (windows-latest):
src/Blockcore/P2P/PeerConnector.cs#L45
Provide an overridable implementation of Dispose(bool) on 'PeerConnector' or mark the type as sealed. A call to Dispose(false) should only clean up native resources. A call to Dispose(true) should clean up both managed and native resources. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063)
|
integrationTest (windows-latest):
src/Blockcore/NBitcoin/BitcoinStream.cs#L22
Provide an overridable implementation of Dispose(bool) on 'Scope' or mark the type as sealed. A call to Dispose(false) should only clean up native resources. A call to Dispose(true) should clean up both managed and native resources. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063)
|
integrationTest (windows-latest):
src/Blockcore/P2P/Peer/NetworkPeer.cs#L103
Provide an overridable implementation of Dispose(bool) on 'NetworkPeer' or mark the type as sealed. A call to Dispose(false) should only clean up native resources. A call to Dispose(true) should clean up both managed and native resources. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063)
|
integrationTest (windows-latest):
src/Blockcore/P2P/Peer/NetworkPeerConnection.cs#L24
Provide an overridable implementation of Dispose(bool) on 'NetworkPeerConnection' or mark the type as sealed. A call to Dispose(false) should only clean up native resources. A call to Dispose(true) should clean up both managed and native resources. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063)
|
integrationTest (windows-latest):
src/Blockcore/P2P/Peer/NetworkPeerDisposer.cs#L28
Provide an overridable implementation of Dispose(bool) on 'NetworkPeerDisposer' or mark the type as sealed. A call to Dispose(false) should only clean up native resources. A call to Dispose(true) should clean up both managed and native resources. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063)
|
integrationTest (windows-latest):
src/Blockcore/P2P/Peer/NetworkPeerListener.cs#L13
Provide an overridable implementation of Dispose(bool) on 'NetworkPeerListener' or mark the type as sealed. A call to Dispose(false) should only clean up native resources. A call to Dispose(true) should clean up both managed and native resources. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063)
|
integrationTest (windows-latest):
src/Blockcore/P2P/Peer/NetworkPeerServer.cs#L20
Provide an overridable implementation of Dispose(bool) on 'NetworkPeerServer' or mark the type as sealed. A call to Dispose(false) should only clean up native resources. A call to Dispose(true) should clean up both managed and native resources. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063)
|