feat: remove the disable state from chat input box #1341
+26
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kang-square
changed the title
kang-square
commented
Feb 22, 2025
| onClick={onStop} | ||
| onClick={(e) => { | ||
| e.preventDefault(); | ||
| e.stopPropagation(); |
There was a problem hiding this comment.
Need to add preventDefault and stopPropagation here, otherwise it triggers a bug when Goose is generating, and there is text in the input box, and you click on the stop button, the text is submitted.
I guess it's because when we clicks on the stop button, the isLoading changes from true to false, and it renders the submit button. When the click event bubble up, its parent element is the form, so it triggers the form submit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to implement the feature mentioned in this issue.
I remove the disable state from the chat input box, while the Goose is generating.
The
Entershortcut to submit is still disabled when Goose is generating.Screen.Recording.2025-02-22.at.12.42.08.AM-1.mov