Skip to content

Commit

Permalink
Kibana Discover support kibana 8.14/8.15
Browse files Browse the repository at this point in the history
  • Loading branch information
nsano-rururu committed Oct 7, 2024
1 parent e3fba4c commit b44a62c
Show file tree
Hide file tree
Showing 4 changed files with 25 additions and 23 deletions.
2 changes: 1 addition & 1 deletion docs/source/ruletypes.rst
Original file line number Diff line number Diff line change
Expand Up @@ -746,7 +746,7 @@ kibana_discover_version
The currently supported versions of Kibana Discover are:

- `7.0`, `7.1`, `7.2`, `7.3`, `7.4`, `7.5`, `7.6`, `7.7`, `7.8`, `7.9`, `7.10`, `7.11`, `7.12`, `7.13`, `7.14`, `7.15`, `7.16`, `7.17`
- `8.0`, `8.1`, `8.2`, `8.3`, `8.4`, `8.5`, `8.6`, `8.7`, `8.8`, `8.9` , `8.10` , `8.11` , `8.12` , `8.13`
- `8.0`, `8.1`, `8.2`, `8.3`, `8.4`, `8.5`, `8.6`, `8.7`, `8.8`, `8.9` , `8.10` , `8.11` , `8.12` , `8.13`, `8.14`, `8.15`

``kibana_discover_version: '7.15'``

Expand Down
2 changes: 1 addition & 1 deletion elastalert/kibana_discover.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@

kibana_versions = frozenset([
'7.0', '7.1', '7.2', '7.3', '7.4', '7.5', '7.6', '7.7', '7.8', '7.9', '7.10', '7.11', '7.12', '7.13', '7.14', '7.15', '7.16', '7.17',
'8.0', '8.1', '8.2', '8.3', '8.4', '8.5', '8.6', '8.7', '8.8', '8.9', '8.10', '8.11', '8.12', '8.13'
'8.0', '8.1', '8.2', '8.3', '8.4', '8.5', '8.6', '8.7', '8.8', '8.9', '8.10', '8.11', '8.12', '8.13', '8.14', '8.15'
])

def generate_kibana_discover_url(rule, match):
Expand Down
2 changes: 1 addition & 1 deletion elastalert/schema.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -324,7 +324,7 @@ properties:
generate_kibana_discover_url: {type: boolean}
shorten_kibana_discover_url: {type: boolean}
kibana_discover_app_url: {type: string}
kibana_discover_version: {type: string, enum: ['8.13','8.12','8.11', '8.10', '8.9', '8.8', '8.7', '8.6', '8.5', '8.4', '8.3', '8.2', '8.1', '8.0', '7.17', '7.16', '7.15', '7.14', '7.13', '7.12', '7.11', '7.10', '7.9', '7.8', '7.7', '7.6', '7.5', '7.4', '7.3', '7.2', '7.1', '7.0']}
kibana_discover_version: {type: string, enum: ['8.15','8.14','8.13','8.12','8.11', '8.10', '8.9', '8.8', '8.7', '8.6', '8.5', '8.4', '8.3', '8.2', '8.1', '8.0', '7.17', '7.16', '7.15', '7.14', '7.13', '7.12', '7.11', '7.10', '7.9', '7.8', '7.7', '7.6', '7.5', '7.4', '7.3', '7.2', '7.1', '7.0']}
kibana_discover_index_pattern_id: {type: string, minLength: 1}
kibana_discover_columns: {type: array, items: {type: string, minLength: 1}, minItems: 1}
kibana_discover_from_timedelta: *timedelta
Expand Down
42 changes: 22 additions & 20 deletions tests/kibana_discover_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,9 @@
'8.10',
'8.11',
'8.12',
'8.13'
'8.13',
'8.14',
'8.15'
])
def test_generate_kibana_discover_url_with_kibana_7x(kibana_version):
url = generate_kibana_discover_url(
Expand Down Expand Up @@ -74,7 +76,7 @@ def test_generate_kibana_discover_url_with_relative_kibana_discover_app_url():
url = generate_kibana_discover_url(
rule={
'kibana_discover_app_url': 'app/discover#/',
'kibana_discover_version': '8.13',
'kibana_discover_version': '8.15',
'kibana_discover_index_pattern_id': '620ad0e6-43df-4557-bda2-384960fa9086',
'timestamp_field': 'timestamp'
},
Expand Down Expand Up @@ -120,7 +122,7 @@ def test_generate_kibana_discover_url_with_missing_kibana_discover_version():
def test_generate_kibana_discover_url_with_missing_kibana_discover_app_url():
url = generate_kibana_discover_url(
rule={
'kibana_discover_version': '8.13',
'kibana_discover_version': '8.15',
'kibana_discover_index_pattern_id': 'logs',
'timestamp_field': 'timestamp',
'name': 'test'
Expand All @@ -136,7 +138,7 @@ def test_generate_kibana_discover_url_with_missing_kibana_discover_index_pattern
url = generate_kibana_discover_url(
rule={
'kibana_discover_app_url': 'http://kibana:5601/#/discover',
'kibana_discover_version': '8.13',
'kibana_discover_version': '8.15',
'timestamp_field': 'timestamp',
'name': 'test'
},
Expand Down Expand Up @@ -170,7 +172,7 @@ def test_generate_kibana_discover_url_with_kibana_discover_app_url_env_substitut
url = generate_kibana_discover_url(
rule={
'kibana_discover_app_url': 'http://$KIBANA_HOST:$KIBANA_PORT/#/discover',
'kibana_discover_version': '8.13',
'kibana_discover_version': '8.15',
'kibana_discover_index_pattern_id': 'd6cabfb6-aaef-44ea-89c5-600e9a76991a',
'timestamp_field': 'timestamp'
},
Expand Down Expand Up @@ -202,7 +204,7 @@ def test_generate_kibana_discover_url_with_from_timedelta():
url = generate_kibana_discover_url(
rule={
'kibana_discover_app_url': 'http://kibana:5601/#/discover',
'kibana_discover_version': '8.13',
'kibana_discover_version': '8.15',
'kibana_discover_index_pattern_id': 'd6cabfb6-aaef-44ea-89c5-600e9a76991a',
'kibana_discover_from_timedelta': timedelta(hours=1),
'timestamp_field': 'timestamp'
Expand Down Expand Up @@ -235,7 +237,7 @@ def test_generate_kibana_discover_url_with_from_timedelta_and_timeframe():
url = generate_kibana_discover_url(
rule={
'kibana_discover_app_url': 'http://kibana:5601/#/discover',
'kibana_discover_version': '8.13',
'kibana_discover_version': '8.15',
'kibana_discover_index_pattern_id': 'd6cabfb6-aaef-44ea-89c5-600e9a76991a',
'kibana_discover_from_timedelta': timedelta(hours=1),
'timeframe': timedelta(minutes=20),
Expand Down Expand Up @@ -269,7 +271,7 @@ def test_generate_kibana_discover_url_with_to_timedelta():
url = generate_kibana_discover_url(
rule={
'kibana_discover_app_url': 'http://kibana:5601/#/discover',
'kibana_discover_version': '8.13',
'kibana_discover_version': '8.15',
'kibana_discover_index_pattern_id': 'd6cabfb6-aaef-44ea-89c5-600e9a76991a',
'kibana_discover_to_timedelta': timedelta(hours=1),
'timestamp_field': 'timestamp'
Expand Down Expand Up @@ -302,7 +304,7 @@ def test_generate_kibana_discover_url_with_to_timedelta_and_timeframe():
url = generate_kibana_discover_url(
rule={
'kibana_discover_app_url': 'http://kibana:5601/#/discover',
'kibana_discover_version': '8.13',
'kibana_discover_version': '8.15',
'kibana_discover_index_pattern_id': 'd6cabfb6-aaef-44ea-89c5-600e9a76991a',
'kibana_discover_to_timedelta': timedelta(hours=1),
'timeframe': timedelta(minutes=20),
Expand Down Expand Up @@ -336,7 +338,7 @@ def test_generate_kibana_discover_url_with_timeframe():
url = generate_kibana_discover_url(
rule={
'kibana_discover_app_url': 'http://kibana:5601/#/discover',
'kibana_discover_version': '8.13',
'kibana_discover_version': '8.15',
'kibana_discover_index_pattern_id': 'd6cabfb6-aaef-44ea-89c5-600e9a76991a',
'timeframe': timedelta(minutes=20),
'timestamp_field': 'timestamp'
Expand Down Expand Up @@ -369,7 +371,7 @@ def test_generate_kibana_discover_url_with_custom_columns():
url = generate_kibana_discover_url(
rule={
'kibana_discover_app_url': 'http://kibana:5601/#/discover',
'kibana_discover_version': '8.13',
'kibana_discover_version': '8.15',
'kibana_discover_index_pattern_id': 'logs-*',
'kibana_discover_columns': ['level', 'message'],
'timestamp_field': 'timestamp'
Expand Down Expand Up @@ -402,7 +404,7 @@ def test_generate_kibana_discover_url_with_single_filter():
url = generate_kibana_discover_url(
rule={
'kibana_discover_app_url': 'http://kibana:5601/#/discover',
'kibana_discover_version': '8.13',
'kibana_discover_version': '8.15',
'kibana_discover_index_pattern_id': 'logs-*',
'timestamp_field': 'timestamp',
'filter': [
Expand Down Expand Up @@ -453,7 +455,7 @@ def test_generate_kibana_discover_url_with_multiple_filters():
url = generate_kibana_discover_url(
rule={
'kibana_discover_app_url': 'http://kibana:5601/#/discover',
'kibana_discover_version': '8.13',
'kibana_discover_version': '8.15',
'kibana_discover_index_pattern_id': '90943e30-9a47-11e8-b64d-95841ca0b247',
'timestamp_field': 'timestamp',
'filter': [
Expand Down Expand Up @@ -507,7 +509,7 @@ def test_generate_kibana_discover_url_with_int_query_key():
url = generate_kibana_discover_url(
rule={
'kibana_discover_app_url': 'http://kibana:5601/#/discover',
'kibana_discover_version': '8.13',
'kibana_discover_version': '8.15',
'kibana_discover_index_pattern_id': 'logs-*',
'timestamp_field': 'timestamp',
'query_key': 'geo.dest'
Expand Down Expand Up @@ -567,7 +569,7 @@ def test_generate_kibana_discover_url_with_str_query_key():
url = generate_kibana_discover_url(
rule={
'kibana_discover_app_url': 'http://kibana:5601/#/discover',
'kibana_discover_version': '8.13',
'kibana_discover_version': '8.15',
'kibana_discover_index_pattern_id': 'logs-*',
'timestamp_field': 'timestamp',
'query_key': 'geo.dest'
Expand Down Expand Up @@ -629,7 +631,7 @@ def test_generate_kibana_discover_url_with_null_query_key_value():
url = generate_kibana_discover_url(
rule={
'kibana_discover_app_url': 'http://kibana:5601/#/discover',
'kibana_discover_version': '8.13',
'kibana_discover_version': '8.15',
'kibana_discover_index_pattern_id': 'logs-*',
'timestamp_field': 'timestamp',
'query_key': 'status'
Expand Down Expand Up @@ -679,7 +681,7 @@ def test_generate_kibana_discover_url_with_missing_query_key_value():
url = generate_kibana_discover_url(
rule={
'kibana_discover_app_url': 'http://kibana:5601/#/discover',
'kibana_discover_version': '8.13',
'kibana_discover_version': '8.15',
'kibana_discover_index_pattern_id': 'logs-*',
'timestamp_field': 'timestamp',
'query_key': 'status'
Expand Down Expand Up @@ -728,7 +730,7 @@ def test_generate_kibana_discover_url_with_compound_query_key():
url = generate_kibana_discover_url(
rule={
'kibana_discover_app_url': 'http://kibana:5601/#/discover',
'kibana_discover_version': '8.13',
'kibana_discover_version': '8.15',
'kibana_discover_index_pattern_id': 'logs-*',
'timestamp_field': 'timestamp',
'compound_query_key': ['geo.src', 'geo.dest'],
Expand Down Expand Up @@ -816,7 +818,7 @@ def test_generate_kibana_discover_url_with_filter_and_query_key():
url = generate_kibana_discover_url(
rule={
'kibana_discover_app_url': 'http://kibana:5601/#/discover',
'kibana_discover_version': '8.13',
'kibana_discover_version': '8.15',
'kibana_discover_index_pattern_id': 'logs-*',
'timestamp_field': 'timestamp',
'filter': [
Expand Down Expand Up @@ -893,7 +895,7 @@ def test_generate_kibana_discover_url_with_querystring_filter_and_query_key():
url = generate_kibana_discover_url(
rule={
'kibana_discover_app_url': 'http://kibana:5601/#/discover',
'kibana_discover_version': '8.13',
'kibana_discover_version': '8.15',
'kibana_discover_index_pattern_id': 'logs-*',
'timestamp_field': 'timestamp',
'filter': [
Expand Down

0 comments on commit b44a62c

Please sign in to comment.