Skip to content

Commit

Permalink
dm space map metadata: fix missing store of apply_bops() return value
Browse files Browse the repository at this point in the history
In commit 6096d91 ("dm space map metadata: fix occasional leak
of a metadata block on resize"), we refactor the commit logic to a new
function 'apply_bops'.  But when that logic was replaced in out() the
return value was not stored.  This may lead out() returning a wrong
value to the caller.

Fixes: 6096d91 ("dm space map metadata: fix occasional leak of a metadata block on resize")
Cc: [email protected]
Signed-off-by: ZhangXiaoxu <[email protected]>
Signed-off-by: Mike Snitzer <[email protected]>
  • Loading branch information
z00467499 authored and snitm committed Aug 22, 2019
1 parent e4f9d60 commit ae14824
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/md/persistent-data/dm-space-map-metadata.c
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,7 @@ static int out(struct sm_metadata *smm)
}

if (smm->recursion_count == 1)
apply_bops(smm);
r = apply_bops(smm);

smm->recursion_count--;

Expand Down

0 comments on commit ae14824

Please sign in to comment.