feat: expand listing filters #4628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for partners-bloom-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for bloom-exygy-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for bloom-public-seeds ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for partners-bloom-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for bloom-exygy-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for bloom-public-seeds ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ludtkemorgan
reviewed
Feb 4, 2025
4542. This will reduce flakyness
YazeedLoonat
requested changes
Feb 13, 2025
YazeedLoonat
added
needs changes
mcgarrye
added
2 reviews needed
YazeedLoonat
added
1 review needed
ludtkemorgan
approved these changes
Feb 17, 2025
ludtkemorgan
added
ready to merge
mcgarrye
removed
the
ready to merge
mcgarrye
added a commit
to housingbayarea/bloom
that referenced
this pull request
Feb 18, 2025
* feat: expand listing filters 4542 * feat: test for expanded listing filters 4542 * feat: remove unused imports 4542 * feat: add e2e tests and corrections 4542 * feat: add test for search 4542 * feat: correct linting and small changes 4542 * feat: make test more unique 4542 * feat: increase response limit 4542 * feat: always filter by jurisdiction 4542. This will reduce flakyness * feat: fix swagger file 5442 * feat: separate dtos 4542
mcgarrye
added a commit
to metrotranscom/doorway
that referenced
this pull request
Feb 18, 2025
* feat: expand listing filters 4542 * feat: test for expanded listing filters 4542 * feat: remove unused imports 4542 * feat: add e2e tests and corrections 4542 * feat: add test for search 4542 * feat: correct linting and small changes 4542 * feat: make test more unique 4542 * feat: increase response limit 4542 * feat: always filter by jurisdiction 4542. This will reduce flakyness * feat: fix swagger file 5442 * feat: separate dtos 4542
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #(4542)
Description
Adds the filters described in the ticket, as well as any missing filters in Doorway.
Logic has been alphabetized for read-ability. Unit tests were added for all filters. Should have no impact on existing functionality in Core, HBA or Doorway.
How Can This Be Tested/Reviewed?
Start up the backend API.
Using the OpenAPI, call the POST
listings/listendpoint.Adjust the
filtersto test each filter.Note1: the
searchfield at the bottom of the sample payload will prevent anything from being found if not removed or changed.NOTE2: we do not have any guardrails with which comparisons are used for each case. So using
=on a list or<=on a string orINon a number may have unpredictable results or even 500 errors.Happy path testing for public listings page and partners listing page.
For partners listing page, try the search and signing in as jadmin and partner.
Author Checklist:
yarn generate:clientand/or created a migration when requiredReview Process: