Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: partners listing page integration tests #4635

Merged
merged 12 commits into from
Feb 11, 2025

Conversation

matzduniuk
Copy link
Collaborator

This PR addresses #4570

  • Addresses the issue in full
  • Addresses only certain aspects of the issue

Description

  • Extensive suite of integration tests for the partners' site single listing page
  • Small code cleanup by removing unnecessary type assertions
  • Adding missing translations to the general.json translation files

Remaining Issues:

  • The <FieldValue> shared component uses a <p> as a wrapper for the children component, which raises console errors when some elements are passed (e.g.: <div>, <ul>)>. This error does not interfere with the application's operation. Still, it could be fixed by either replacing the <p> element with <span> or adding a new optional prop for selecting a type of wrapper component.

  • The amiCharts API call for the unit details drawer "Eligibility" section proved to be difficult to capture for mocking therefore, this field has been tested only for properly displaying the field label and the missing data placeholder.

  • Newly added label strings are missing translation for languages outside of English

How Can This Be Tested/Reviewed?

Run the full suite of test using command:

yarn jest --verbose -t "listing data"

Author Checklist:

  • Added QA notes to the issue with applicable URLs
  • Reviewed in a desktop view
  • Reviewed in a mobile view
  • Reviewed considering accessibility
  • Added tests covering the changes
  • Made corresponding changes to the documentation
  • Ran yarn generate:client and/or created a migration when required

Review Process:

  • Read and understand the issue
  • Ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Either (1) explicitly ask a clarifying question, (2) request changes, or (3) approve the PR, even if there are very small remaining changes, if you don't need to re-review after the updates

@matzduniuk matzduniuk added the 1 review needed Requires 1 more review before ready to merge label Feb 6, 2025
@matzduniuk matzduniuk self-assigned this Feb 6, 2025
Copy link

netlify bot commented Feb 6, 2025

Deploy Preview for bloom-public-seeds ready!

Name Link
🔨 Latest commit bd43b1c
🔍 Latest deploy log https://app.netlify.com/sites/bloom-public-seeds/deploys/67ab489ce692310008ed3d8d
😎 Deploy Preview https://deploy-preview-4635--bloom-public-seeds.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 6, 2025

Deploy Preview for bloom-exygy-dev ready!

Name Link
🔨 Latest commit bd43b1c
🔍 Latest deploy log https://app.netlify.com/sites/bloom-exygy-dev/deploys/67ab489c500de20008b438f0
😎 Deploy Preview https://deploy-preview-4635--bloom-exygy-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 6, 2025

Deploy Preview for partners-bloom-dev ready!

Name Link
🔨 Latest commit bd43b1c
🔍 Latest deploy log https://app.netlify.com/sites/partners-bloom-dev/deploys/67ab489ce663ed0009a77e24
😎 Deploy Preview https://deploy-preview-4635--partners-bloom-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@emilyjablonski emilyjablonski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look awesome! And the coverage reports look great. Just need to move the strings over to the other file.

@emilyjablonski emilyjablonski added ready to merge Should be applied when a PR has been reviewed and approved and removed 1 review needed Requires 1 more review before ready to merge labels Feb 10, 2025
@emilyjablonski emilyjablonski changed the title 4570/Partners listing page integration tests test: partners listing page integration tests Feb 10, 2025
@matzduniuk matzduniuk merged commit 3665d85 into main Feb 11, 2025
24 checks passed
@matzduniuk matzduniuk deleted the 4570/partners-lisitng-page-integration-tests branch February 11, 2025 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Should be applied when a PR has been reviewed and approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants