-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: partners listing page integration tests #4635
test: partners listing page integration tests #4635
Conversation
✅ Deploy Preview for bloom-public-seeds ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for bloom-exygy-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for partners-bloom-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These look awesome! And the coverage reports look great. Just need to move the strings over to the other file.
This PR addresses #4570
Description
Remaining Issues:
The
<FieldValue>
shared component uses a<p>
as a wrapper for the children component, which raises console errors when some elements are passed (e.g.:<div>
,<ul>
)>. This error does not interfere with the application's operation. Still, it could be fixed by either replacing the<p>
element with<span>
or adding a new optional prop for selecting a type of wrapper component.The
amiCharts
API call for the unit details drawer "Eligibility" section proved to be difficult to capture for mocking therefore, this field has been tested only for properly displaying the field label and the missing data placeholder.Newly added label strings are missing translation for languages outside of English
How Can This Be Tested/Reviewed?
Run the full suite of test using command:
Author Checklist:
yarn generate:client
and/or created a migration when requiredReview Process: