Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: occupancy issues #4640

Merged
merged 5 commits into from
Feb 18, 2025
Merged

fix: occupancy issues #4640

merged 5 commits into from
Feb 18, 2025

Conversation

emilyjablonski
Copy link
Collaborator

@emilyjablonski emilyjablonski commented Feb 11, 2025

This PR addresses #4641

  • Addresses the issue in full

Description

Fixes bugs we have in the occupancy table that cause rows to sometimes display null as well as adds missing translations (confirmed w product to use google translate).

How Can This Be Tested/Reviewed?

The following screenshots have this data in each row:

  1. Same min/max
  2. No data at all
  3. Different min/max
  4. Just min
  5. Just max

Prod

Screenshot 2025-02-11 at 2 30 49 PM
Screenshot 2025-02-11 at 2 30 57 PM

This PR

Screenshot 2025-02-11 at 2 28 41 PM
Screenshot 2025-02-11 at 2 28 53 PM

Author Checklist:

  • Added QA notes to the issue with applicable URLs
  • Reviewed in a desktop view
  • Reviewed in a mobile view
  • Reviewed considering accessibility
  • Added tests covering the changes
  • Made corresponding changes to the documentation
  • Ran yarn generate:client and/or created a migration when required

Review Process:

  • Read and understand the issue
  • Ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Either (1) explicitly ask a clarifying question, (2) request changes, or (3) approve the PR, even if there are very small remaining changes, if you don't need to re-review after the updates

Copy link

netlify bot commented Feb 11, 2025

Deploy Preview for bloom-public-seeds ready!

Name Link
🔨 Latest commit 97af373
🔍 Latest deploy log https://app.netlify.com/sites/bloom-public-seeds/deploys/67b4bee54510dd00088409f2
😎 Deploy Preview https://deploy-preview-4640--bloom-public-seeds.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 11, 2025

Deploy Preview for partners-bloom-dev ready!

Name Link
🔨 Latest commit 97af373
🔍 Latest deploy log https://app.netlify.com/sites/partners-bloom-dev/deploys/67b4bee514d2ab0007b4045d
😎 Deploy Preview https://deploy-preview-4640--partners-bloom-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 11, 2025

Deploy Preview for bloom-exygy-dev ready!

Name Link
🔨 Latest commit 97af373
🔍 Latest deploy log https://app.netlify.com/sites/bloom-exygy-dev/deploys/67b4bee5ded1f20008a28203
😎 Deploy Preview https://deploy-preview-4640--bloom-exygy-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@emilyjablonski emilyjablonski marked this pull request as ready for review February 11, 2025 22:08
@emilyjablonski emilyjablonski added the 1 review needed Requires 1 more review before ready to merge label Feb 11, 2025
Copy link
Collaborator

@YazeedLoonat YazeedLoonat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, small nitpick logical update!

shared-helpers/src/views/occupancyFormatting.tsx Outdated Show resolved Hide resolved
@YazeedLoonat YazeedLoonat added ready to merge Should be applied when a PR has been reviewed and approved and removed 1 review needed Requires 1 more review before ready to merge labels Feb 12, 2025
@emilyjablonski emilyjablonski merged commit 721d53e into main Feb 18, 2025
24 checks passed
@emilyjablonski emilyjablonski deleted the occupancy-issues branch February 18, 2025 18:17
emilyjablonski added a commit to housingbayarea/bloom that referenced this pull request Feb 18, 2025
emilyjablonski added a commit to housingbayarea/bloom that referenced this pull request Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Should be applied when a PR has been reviewed and approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants