Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default namespace default to ServiceAccount definition in example yaml #142

Merged
merged 2 commits into from
Apr 12, 2024

Conversation

abctaylor
Copy link
Contributor

This is to catch the case where users find-replace the default namespace with another namespace (say, goldpinger but don't change it for the ServiceAccount definition.

Issue number of the reported bug or feature request: #

Describe your changes
Added a namespace key under metadata with corresponding namespace (default) used elsewhere in the sample yaml.

Testing performed
Tested on prem, k8s 1.27 with kubectl apply -f file.yaml.

Additional context
N/A.

@skamboj
Copy link
Contributor

skamboj commented Apr 8, 2024

Thank you so much for your contribution. This looks good. We do need a DCO before we can approve this - please see this link: https://github.com/bloomberg/goldpinger/blob/master/CONTRIBUTING.md#contribution-licensing for details.

@abctaylor
Copy link
Contributor Author

@skamboj did I not already do it in my first commit? LMK if something is wrong syntactically:
image

@skamboj
Copy link
Contributor

skamboj commented Apr 8, 2024

@skamboj did I not already do it in my first commit? LMK if something is wrong syntactically: image

Sorry the reason it failed is given here: https://github.com/bloomberg/goldpinger/runs/23516585421

Commit sha: [bda1235](https://github.com/bloomberg/goldpinger/pull/142/commits/bda1235c406be80ee1c3fa6189b6d3c8dd193889), Author: ABC Taylor, Committer: ABC Taylor; Expected "ABC Taylor [[email protected]](mailto:[email protected])", but got "Andrew Taylor [[email protected]](mailto:[email protected])".

I think it was expecting ABC Taylor and got Andrew Taylor instead.

…h case where users find-replace `default` with another namespace but don't change it for the ServiceAccount

Signed-Off-By: ABC Taylor <[email protected]>
@abctaylor abctaylor force-pushed the abctaylor-serviceaccount branch from bda1235 to 562df92 Compare April 11, 2024 07:37
@abctaylor
Copy link
Contributor Author

@skamboj I have now --amended the message.

Copy link
Contributor

@skamboj skamboj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, :shipit:

@skamboj skamboj merged commit 41af078 into bloomberg:master Apr 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants