ofp-port: Fix null dereference parsing Intel custom statistics.

Reported-at: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=9788 Fixes: 7333c3b ("ofp-port: Fix buffer overread parsing Intel custom statistics.") Signed-off-by: Ben Pfaff <[email protected]>
blp · Aug 18, 2018 · 11f8e96 · 11f8e96
1 parent 20cdd1d
commit 11f8e96
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/lib/ofp-port.c b/lib/ofp-port.c
@@ -1616,7 +1616,7 @@ parse_intel_port_custom_property(struct ofpbuf *payload,
 
         /* Counter name. */
         uint8_t *name_len = ofpbuf_try_pull(payload, sizeof *name_len);
-        char *name = ofpbuf_try_pull(payload, *name_len);
+        char *name = name_len ? ofpbuf_try_pull(payload, *name_len) : NULL;
         if (!name_len || !name) {
             return OFPERR_OFPBPC_BAD_LEN;
         }