ovsdb-idl: omit_alert should implicitly turn off tracking.

OVSDB_IDL_TRACK is not valid without OVSDB_IDL_ALERT, so it should be turned off as well in ovsdb_idl_omit_alert(). Signed-off-by: Han Zhou <[email protected]> Signed-off-by: Ben Pfaff <[email protected]>
blp · Apr 4, 2018 · b97b1f0 · b97b1f0
1 parent c20ab6a
commit b97b1f0
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/lib/ovsdb-idl.c b/lib/ovsdb-idl.c
@@ -1512,7 +1512,7 @@ ovsdb_idl_send_cond_change(struct ovsdb_idl *idl)
     }
 }
 
-/* Turns off OVSDB_IDL_ALERT for 'column' in 'db'.
+/* Turns off OVSDB_IDL_ALERT and OVSDB_IDL_TRACK for 'column' in 'db'.
  *
  * This function should be called between ovsdb_idl_create() and the first call
  * to ovsdb_idl_run().
@@ -1521,10 +1521,10 @@ static void
 ovsdb_idl_db_omit_alert(struct ovsdb_idl_db *db,
                         const struct ovsdb_idl_column *column)
 {
-    *ovsdb_idl_db_get_mode(db, column) &= ~OVSDB_IDL_ALERT;
+    *ovsdb_idl_db_get_mode(db, column) &= ~(OVSDB_IDL_ALERT | OVSDB_IDL_TRACK);
 }
 
-/* Turns off OVSDB_IDL_ALERT for 'column' in 'idl'.
+/* Turns off OVSDB_IDL_ALERT and OVSDB_IDL_TRACK for 'column' in 'idl'.
  *
  * This function should be called between ovsdb_idl_create() and the first call
  * to ovsdb_idl_run().