Skip to content

Commit

Permalink
tests/stp: Make validation of flows before changing of topology.
Browse files Browse the repository at this point in the history
The change fixes random stp test failure. Accuracy is about 20%.
Failed test is following:
2337: STP - flush the fdb and mdb when topology changed

In some cases, a validation is executed after topology change and
it increase time of stp stabilization. To prevent this, delay
which wait validation is added before deleting a port.

CC: Tonghao Zhang <[email protected]>
Fixes: 427e975 ("tests: Add and improve stp tests.")
Signed-off-by: Ivan Dyukov <[email protected]>
Signed-off-by: Ben Pfaff <[email protected]>
  • Loading branch information
Ivan Dyukov authored and blp committed Jun 14, 2018
1 parent 19aac14 commit fcb8664
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions tests/stp.at
Original file line number Diff line number Diff line change
Expand Up @@ -562,6 +562,9 @@ OVS_WAIT_UNTIL([ovs-appctl mdb/show br0 | grep 'querier'])
OVS_WAIT_UNTIL([ovs-appctl mdb/show br1 | grep 'querier'])
OVS_WAIT_UNTIL([ovs-appctl mdb/show br2 | grep 'querier'])

# Make sure that validation of flows was before changing of topology.
ovs-appctl revalidator/wait

# del p2 on the br0, the topology will be changed
AT_CHECK([ovs-vsctl del-port br0 p2])

Expand Down

0 comments on commit fcb8664

Please sign in to comment.