dpctl: Fix shadowed iterator in show_dpif().

Signed-off-by: Justin Pettit <[email protected]> Acked-by: Daniele Di Proietto <[email protected]>
blp · Jul 13, 2016 · 270fa6d · 270fa6d
1 parent f95523c
commit 270fa6d
Showing 1 changed file with 4 additions and 7 deletions.
diff --git a/lib/dpctl.c b/lib/dpctl.c
@@ -577,13 +577,10 @@ show_dpif(struct dpif *dpif, struct dpctl_params *dpctl_p)
                 smap_init(&config);
                 error = netdev_get_config(netdev, &config);
                 if (!error) {
-                    const struct smap_node **nodes;
-                    size_t i;
-
-                    nodes = smap_sort(&config);
-                    for (i = 0; i < smap_count(&config); i++) {
-                        const struct smap_node *node = nodes[i];
-                        dpctl_print(dpctl_p, "%c %s=%s", i ? ',' : ':',
+                    const struct smap_node **nodes = smap_sort(&config);
+                    for (size_t j = 0; j < smap_count(&config); j++) {
+                        const struct smap_node *node = nodes[j];
+                        dpctl_print(dpctl_p, "%c %s=%s", j ? ',' : ':',
                                     node->key, node->value);
                     }
                     free(nodes);