Restrict access to computed attributes (AC-2018-10-8-1)

blueguyzhu · Oct 12, 2018 · d15fa5e · d15fa5e
1 parent 32a0476
commit d15fa5e
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/web/app/view/SettingsMenuController.js b/web/app/view/SettingsMenuController.js
@@ -45,6 +45,8 @@ Ext.define('Traccar.view.SettingsMenuController', {
         if (admin) {
             this.lookupReference('settingsServerButton').setHidden(false);
             this.lookupReference('settingsStatisticsButton').setHidden(false);
+            this.lookupReference('settingsComputedAttributesButton').setHidden(
+                Traccar.app.getBooleanAttributePreference('ui.disableComputedAttributes'));
         }
         if (admin || manager) {
             this.lookupReference('settingsUsersButton').setHidden(false);
@@ -62,10 +64,6 @@ Ext.define('Traccar.view.SettingsMenuController', {
             this.lookupReference('settingsMaintenancesButton').setHidden(
                 Traccar.app.getVehicleFeaturesDisabled() || Traccar.app.getBooleanAttributePreference('ui.disableMaintenances'));
         }
-        if (admin || !deviceReadonly && !readonly) {
-            this.lookupReference('settingsComputedAttributesButton').setHidden(
-                Traccar.app.getBooleanAttributePreference('ui.disableComputedAttributes'));
-        }
     },
 
     onUserClick: function () {