Make sure always reload table on main thread

bluesea · Feb 16, 2020 · f58f9a0 · f58f9a0
1 parent 2ecd779
commit f58f9a0
Showing 1 changed file with 10 additions and 6 deletions.
diff --git a/iina/FilterWindowController.swift b/iina/FilterWindowController.swift
@@ -71,11 +71,17 @@ class FilterWindowController: NSWindowController, NSWindowDelegate {
 
     // notifications
     let notiName: Notification.Name = filterType == MPVProperty.af ? .iinaAFChanged : .iinaVFChanged
-    NotificationCenter.default.addObserver(self, selector: #selector(reloadTable), name: notiName, object: nil)
-    NotificationCenter.default.addObserver(self, selector: #selector(reloadTable), name: .iinaMainWindowChanged, object: nil)
+    NotificationCenter.default.addObserver(self, selector: #selector(reloadTableInMainThread), name: notiName, object: nil)
+    NotificationCenter.default.addObserver(self, selector: #selector(reloadTableInMainThread), name: .iinaMainWindowChanged, object: nil)
   }
 
   @objc
+  func reloadTableInMainThread() {
+    DispatchQueue.main.sync {
+      reloadTable()
+    }
+  }
+
   func reloadTable() {
     filters = PlayerCore.active.mpv.getFilters(filterType)
     filterIsSaved = [Bool](repeatElement(false, count: filters.count))
@@ -89,10 +95,8 @@ class FilterWindowController: NSWindowController, NSWindowDelegate {
         }
       }
     }
-    DispatchQueue.main.async {
-      self.currentFiltersTableView.reloadData()
-      self.savedFiltersTableView.reloadData()
-    }
+    currentFiltersTableView.reloadData()
+    savedFiltersTableView.reloadData()
   }
 
   func setFilters() {