Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better tablet layout #7656

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

Better tablet layout #7656

wants to merge 16 commits into from

Conversation

mozzius
Copy link
Member

@mozzius mozzius commented Feb 5, 2025

Fixes #3578

Adds new breakpoints for web:

  1. 1075px to 1200px - right nav visible, main content offset to side
  2. 800px to 1075px - no right nav

I also moved the left nav on the tablet breakpoint to sit next to the content, rather than being stuck to the far left edge

1075px to 1200px

Screenshot 2025-02-06 at 14 27 21

800px to 1075px

Screenshot 2025-02-06 at 14 28 39

Test plan

Check all the screens at the new breakpoints. I have tested:

  1. All the common ones I can think of (timeline, feeds, profile, thread, settings etc)
  2. Logged-out view
  3. Signup queued
  4. Deactivated
  5. Takendown
  6. Onboarding
  7. Auth flow

And make sure there's no regressions on the mobile/desktop breakpoints

Copy link

github-actions bot commented Feb 5, 2025

Old size New size Diff
7.02 MB 7.02 MB 207 B (0.00%)

@arcalinea arcalinea temporarily deployed to samuel/better-tablet - social-app PR #7656 February 6, 2025 14:12 — with Render Destroyed
@arcalinea arcalinea temporarily deployed to samuel/better-tablet - social-app PR #7656 February 6, 2025 14:25 — with Render Destroyed
@mozzius mozzius marked this pull request as ready for review February 6, 2025 14:34
@arcalinea arcalinea temporarily deployed to samuel/better-tablet - social-app PR #7656 February 6, 2025 14:38 — with Render Destroyed
@arcalinea arcalinea temporarily deployed to samuel/better-tablet - social-app PR #7656 February 6, 2025 14:41 — with Render Destroyed
@mozzius mozzius changed the title Better tablet mode Better tablet layout Feb 6, 2025
Copy link
Member

@estrattonbailey estrattonbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clicked around a lot, only issue I found was on the labeler screen. There's some nesting going on here iirc, hence the offset context handling. Might be a clue?

CleanShot 2025-02-06 at 13 48 40@2x

@arcalinea arcalinea temporarily deployed to samuel/better-tablet - social-app PR #7656 February 6, 2025 21:12 — with Render Destroyed
@arcalinea arcalinea temporarily deployed to samuel/better-tablet - social-app PR #7656 February 6, 2025 21:19 — with Render Destroyed
@arcalinea arcalinea temporarily deployed to samuel/better-tablet - social-app PR #7656 February 6, 2025 21:20 — with Render Destroyed
@arcalinea arcalinea temporarily deployed to samuel/better-tablet - social-app PR #7656 February 6, 2025 21:27 — with Render Destroyed
@mozzius
Copy link
Member Author

mozzius commented Feb 6, 2025

Fixed a few more spots:

  1. Labeller screen
  2. Dialogs with centered views inside them (MaybeListPlaceholder in Gif dialog for instance)
  3. Load latest button
  4. Home screen loader

@surfdude29
Copy link
Contributor

This works really well on my iPad (9th gen), nice work @mozzius!

Having the search bar, feed list and Trending visible is a massive improvement, thanks! 🙏

I realise it would be out-of-scope for this PR, but just wondering, how technically feasible would it be in the future to move the PWI language selector to the right nav when in tablet layout? The app language is usually autodetected of course so it's not a big deal, but in case there is a desire to change it this would let tablet users do so when they're viewing the PWI (and without changing the zoom setting) and fix #3578.

@mozzius
Copy link
Member Author

mozzius commented Feb 7, 2025

Great idea @surfdude29! added!

@surfdude29
Copy link
Contributor

Oh nice, thanks! :)

@surfdude29
Copy link
Contributor

One other small point to mention: should Trending be showing up in the PWI? (Fwiw it should imho.)

Sometimes it shows up for me, sometimes not, so reloading the page can occasionally cause it to appear or disappear.

@mozzius
Copy link
Member Author

mozzius commented Feb 7, 2025

It should be showing up, yes. Hailey fixed a bug yesterday which was causing ~1% of requests to fail, so hopefully it should be a little more reliable - however, there's some sort of bug with en-GB which I'm still trying to get to the bottom of

@surfdude29
Copy link
Contributor

surfdude29 commented Feb 7, 2025

Ah ok, maybe I'm running into the en-GB bug on the preview branch.

Edit: Sorry to bother you with yet another thing, but I noticed (on main.bsky.dev) that the X button to close Trending is visible in the PWI. I'm not sure that this is ideal because tapping it brings up this dialog, which doesn't exactly make sense if you're not logged in:

IMG_2784

Is it worth creating an issue for that?

@mozzius
Copy link
Member Author

mozzius commented Feb 7, 2025

Sure, I guess that is broken

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search bar and language selector are not visible in PWI in Safari on iPad
4 participants