Add Platform.normalize_path to ensure standard path strings
#111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MHendricks
force-pushed
the
mikeh/norm_case
branch
2 times, most recently
from
17f49fa to
a077d35
Compare
`WinPlatform.normalize_path` ensures that drive letters are always capitalized. This fixes issues with windows drive letters not being consistently saved in the habcache. When platform_path_map is not used on a habcache'd path the cache would not find and load the cached value.
MHendricks
force-pushed
the
mikeh/norm_case
branch
from
a077d35 to
7265ac7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WinPlatform.normalize_pathensures that drive letters are always capitalized.This fixes issues with windows drive letters not being consistently saved in the habcache. When platform_path_map is not used on a habcache'd path the cache would not find and load the cached value.
Checklist
Types of Changes
Proposed Changes